Merge pull request #17999 from yrudman/fixed-error-with-replication-s…

…etup

Fixed error with replication setup when default exclude list used

lib/miq_pglogical.rb

@@ -144,8 +144,10 @@ def self.default_excludes
   end
 
   def self.save_remote_region(exclusion_list)
+    # part of `MiqRegion.replication_type=` is initialization of default subscription list
     MiqRegion.replication_type = :remote
-    refresh_excludes(YAML.safe_load(exclusion_list))
+    # UI is passing empty 'exclution_list' if there are no changes to default subscription list
+    refresh_excludes(YAML.safe_load(exclusion_list)) unless exclusion_list.empty?
   end
 
   def self.save_global_region(subscriptions_to_save, subscriptions_to_remove)

spec/replication/util/miq_pglogical_spec.rb

@@ -158,6 +158,12 @@
       expect(described_class).to receive(:refresh_excludes).with(YAML.safe_load(tables))
       described_class.save_remote_region(tables)
     end
+
+    it "does not updates list of tables to be excluded from replication if passed parameter is empty" do
+      allow(MiqRegion).to receive(:replication_type=)
+      expect(described_class).not_to receive(:refresh_excludes)
+      described_class.save_remote_region("")
+    end
   end
 
   describe ".save_global_region" do