Use variable and DRY code in MiqExpression

ManageIQ · Aug 27, 2019 · 731f964 · 731f964
1 parent 3558102
commit 731f964
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/miq_expression.rb b/lib/miq_expression.rb
@@ -645,7 +645,9 @@ def self.quote(val, typ)
       target = parse_field_or_tag(val)
       value = target.tag_path_with
       col_type = target.try(:column_type) || "string"
-      return target ? "<value ref=#{target.model.to_s.downcase}, type=#{col_type}>#{value}</value>" : "<value type=#{col_type}>#{value}</value>"
+
+      reference_attribute = target ? "ref=#{target.model.to_s.downcase}, " : " "
+      return "<value #{reference_attribute}type=#{col_type}>#{value}</value>"
     end
     case typ.to_s
     when "string", "text", "boolean", nil