updating update message

ManageIQ · Mar 16, 2017 · 7197086 · 7197086
1 parent a36e29d
commit 7197086
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/app/controllers/api/authentications_controller.rb b/app/controllers/api/authentications_controller.rb
@@ -2,9 +2,9 @@ module Api
   class AuthenticationsController < BaseController
     def edit_resource(type, id, data)
       auth = resource_search(id, type, collection_class(:authentications))
-      raise 'type not currently supported' unless auth.respond_to?(:update_in_provider_queue)
+      raise "Update not supported for #{authentication_ident(auth)}" unless auth.respond_to?(:update_in_provider_queue)
       task_id = auth.update_in_provider_queue(data)
-      action_result(true, "Updating Authentication with id #{id}", :task_id => task_id)
+      action_result(true, "Updating #{authentication_ident(auth)}", :task_id => task_id)
     rescue => err
       action_result(false, err.to_s)
     end

diff --git a/spec/requests/api/authentications_spec.rb b/spec/requests/api/authentications_spec.rb
@@ -136,7 +136,7 @@
         'results' => [
           a_hash_including(
             'success' => true,
-            'message' => "Updating Authentication with id #{auth.id}",
+            'message' => a_string_including('Updating Authentication'),
             'task_id' => a_kind_of(Numeric)
           )
         ]
@@ -155,12 +155,12 @@
         'results' => [
           a_hash_including(
             'success' => true,
-            'message' => "Updating Authentication with id #{auth.id}",
+            'message' => a_string_including('Updating Authentication'),
             'task_id' => a_kind_of(Numeric)
           ),
           a_hash_including(
             'success' => true,
-            'message' => "Updating Authentication with id #{auth_2.id}",
+            'message' => a_string_including('Updating Authentication'),
             'task_id' => a_kind_of(Numeric)
           )
         ]
@@ -215,7 +215,7 @@
 
       expected = {
         'success' => true,
-        'message' => "Updating Authentication with id #{auth.id}",
+        'message' => a_string_including('Updating Authentication'),
         'task_id' => a_kind_of(Numeric)
       }
       expect(response).to have_http_status(:ok)
@@ -230,7 +230,7 @@
 
       expected = {
         'success' => false,
-        'message' => 'type not currently supported'
+        'message' => "Update not supported for Authentication id:#{auth.id} name: '#{auth.name}'"
       }
       expect(response).to have_http_status(:ok)
       expect(response.parsed_body).to include(expected)