Merge pull request #13991 from agrare/bz_1419872_snapshot_failure_not…

…ifications

Create a notification when a snapshot operation fails

app/models/vm_or_template.rb

@@ -1855,6 +1855,14 @@ def check_feature_support(message_prefix)
     [true, nil]
   end
 
+  def create_notification(type, options)
+    Notification.create!(
+      :type    => type,
+      :subject => self,
+      :options => options
+    )
+  end
+
   # this is verbose, helper for generating arel
   def self.arel_coalesce(values)
     Arel::Nodes::NamedFunction.new('COALESCE', values)

app/models/vm_or_template/operations/snapshot.rb

@@ -49,6 +49,9 @@ module VmOrTemplate::Operations::Snapshot
 
   def raw_create_snapshot(name, desc = nil, memory)
     run_command_via_parent(:vm_create_snapshot, :name => name, :desc => desc, :memory => memory)
+  rescue => err
+    create_notification(:vm_snapshot_failure, :error => err.to_s, :snapshot_op => "create")
+    raise MiqVmSnapshotError, err.to_s
   end
 
   def create_snapshot(name, desc = nil, memory = false)

db/fixtures/notification_types.yml

@@ -149,3 +149,8 @@
   :expires_in: 24.hours
   :level: :success
   :audience: global
+- :name: vm_snapshot_failure
+  :message: 'Failed to %{snapshot_op} snapshot of %{subject}: %{error}'
+  :expires_in: 24.hours
+  :level: :warning
+  :audience: global