Move require of spec_helper into .rspec

Because we can! Also because it pads my deletion stats for 2016 far ahead of @jrafanie for a while.
ManageIQ · Jan 19, 2016 · 489a17d · 489a17d
1 parent ca3775f
commit 489a17d
Show file tree

Hide file tree

Showing 942 changed files with 5 additions and 1,625 deletions.
diff --git a/.rspec b/.rspec
@@ -1,2 +1,3 @@
+--require spec_helper
 --color
 --order random
diff --git a/.rspec_ci b/.rspec_ci
@@ -1,3 +1,4 @@
+--require spec_helper
 --color
 --order random
 --profile 25
diff --git a/gems/manageiq_foreman/.rspec b/gems/manageiq_foreman/.rspec
@@ -0,0 +1 @@
+--require spec_helper
diff --git a/gems/manageiq_foreman/spec/connection_spec.rb b/gems/manageiq_foreman/spec/connection_spec.rb
@@ -1,5 +1,3 @@
-require_relative 'spec_helper'
-
 describe ManageiqForeman::Connection do
   before do
     unless connection.api_cached?

diff --git a/gems/manageiq_foreman/spec/inventory_spec.rb b/gems/manageiq_foreman/spec/inventory_spec.rb
@@ -1,5 +1,3 @@
-require_relative 'spec_helper'
-
 describe ManageiqForeman::Inventory do
   describe "#refresh_configuration" do
     it "fetches location details" do

diff --git a/gems/manageiq_foreman/spec/manageiq_foreman_spec.rb b/gems/manageiq_foreman/spec/manageiq_foreman_spec.rb
@@ -1,5 +1,3 @@
-require_relative 'spec_helper'
-
 describe ManageiqForeman do
   it 'should have a version number' do
     expect(ManageiqForeman::VERSION).not_to be_nil

diff --git a/gems/manageiq_foreman/spec/paged_response_spec.rb b/gems/manageiq_foreman/spec/paged_response_spec.rb
@@ -1,5 +1,3 @@
-require_relative 'spec_helper'
-
 describe ManageiqForeman::PagedResponse do
   describe "#initializer" do
     context "with index hash" do

diff --git a/gems/pending/.rspec b/gems/pending/.rspec
@@ -1,3 +1,4 @@
+--require spec_helper
 --color
 --order random
 --format documentation
diff --git a/gems/pending/.rspec_ci b/gems/pending/.rspec_ci
@@ -1,3 +1,4 @@
+--require spec_helper
 --color
 --order random
 --profile
diff --git a/gems/pending/spec/VMwareWebService/MiqVimClientBase_spec.rb b/gems/pending/spec/VMwareWebService/MiqVimClientBase_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'VMwareWebService/MiqVimClientBase'
 
 describe MiqVimClientBase do

diff --git a/gems/pending/spec/VMwareWebService/MiqVimVm_spec.rb b/gems/pending/spec/VMwareWebService/MiqVimVm_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'VMwareWebService/MiqVim'
 
 describe MiqVimVm do

diff --git a/gems/pending/spec/VMwareWebService/VimMappingRegistry_spec.rb b/gems/pending/spec/VMwareWebService/VimMappingRegistry_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'VMwareWebService/VimMappingRegistry'
 
 describe VimMappingRegistry do

diff --git a/gems/pending/spec/appliance_console/certificate_authority_spec.rb b/gems/pending/spec/appliance_console/certificate_authority_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "appliance_console/internal_database_configuration"
 require "appliance_console/external_httpd_authentication"
 require 'appliance_console/principal'

diff --git a/gems/pending/spec/appliance_console/certificate_spec.rb b/gems/pending/spec/appliance_console/certificate_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "fileutils"
 require "appliance_console/certificate"
 

diff --git a/gems/pending/spec/appliance_console/cli_spec.rb b/gems/pending/spec/appliance_console/cli_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "appliance_console/cli"
 
 describe ApplianceConsole::Cli do

diff --git a/gems/pending/spec/appliance_console/database_configuration_spec.rb b/gems/pending/spec/appliance_console/database_configuration_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 require "appliance_console/prompts"
 require "appliance_console/database_configuration"
 require "appliance_console/external_database_configuration"

diff --git a/gems/pending/spec/appliance_console/external_httpd_authentication_spec.rb b/gems/pending/spec/appliance_console/external_httpd_authentication_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 require "active_support/all"
 require "appliance_console/external_httpd_authentication"
 require "appliance_console/prompts"

diff --git a/gems/pending/spec/appliance_console/internal_database_configuration_spec.rb b/gems/pending/spec/appliance_console/internal_database_configuration_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "appliance_console/internal_database_configuration"
 
 describe ApplianceConsole::InternalDatabaseConfiguration do

diff --git a/gems/pending/spec/appliance_console/key_configuration_spec.rb b/gems/pending/spec/appliance_console/key_configuration_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "appliance_console/prompts"
 require "appliance_console/key_configuration"
 

diff --git a/gems/pending/spec/appliance_console/logging_spec.rb b/gems/pending/spec/appliance_console/logging_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 require "appliance_console/logging"
 require "appliance_console/errors"
 

diff --git a/gems/pending/spec/appliance_console/principal_spec.rb b/gems/pending/spec/appliance_console/principal_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "appliance_console/principal"
 
 describe ApplianceConsole::Principal do

diff --git a/gems/pending/spec/appliance_console/prompts_spec.rb b/gems/pending/spec/appliance_console/prompts_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "stringio"
 require "appliance_console/errors"
 require "appliance_console/prompts"

diff --git a/gems/pending/spec/appliance_console/service_group_spec.rb b/gems/pending/spec/appliance_console/service_group_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "appliance_console/service_group"
 require "linux_admin"
 

diff --git a/gems/pending/spec/db/MiqBdb/miq_bdb_page_spec.rb b/gems/pending/spec/db/MiqBdb/miq_bdb_page_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 require 'db/MiqBdb/MiqBdb'
 require "#{__dir__}/test_files"
 

diff --git a/gems/pending/spec/db/MiqBdb/miq_bdb_spec.rb b/gems/pending/spec/db/MiqBdb/miq_bdb_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 require 'db/MiqBdb/MiqBdb'
 require "#{__dir__}/test_files"
 

diff --git a/gems/pending/spec/db/MiqBdb/miq_bdb_util_spec.rb b/gems/pending/spec/db/MiqBdb/miq_bdb_util_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 require 'db/MiqBdb/MiqBdbUtil'
 require "#{__dir__}/test_files"
 

diff --git a/gems/pending/spec/db/MiqSqlite/conary_spec.rb b/gems/pending/spec/db/MiqSqlite/conary_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'db/MiqSqlite/MiqSqlite3'
 
 describe MiqSqlite3DB::MiqSqlite3 do

diff --git a/gems/pending/spec/db/MiqSqlite/varint_spec.rb b/gems/pending/spec/db/MiqSqlite/varint_spec.rb
@@ -1,5 +1,4 @@
 # encoding: US-ASCII
-require "spec_helper"
 require 'db/MiqSqlite/MiqSqlite3'
 
 describe MiqSqlite3DB do

diff --git a/gems/pending/spec/discovery/PortScan_spec.rb b/gems/pending/spec/discovery/PortScan_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'discovery/PortScan'
 
 require 'ostruct'

diff --git a/gems/pending/spec/disk/miq_disk_spec.rb b/gems/pending/spec/disk/miq_disk_spec.rb
@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 require 'ostruct'
 require 'disk/MiqDisk'
 require 'disk/modules/RawDisk'

diff --git a/gems/pending/spec/disk/modules/raw_disk_spec.rb b/gems/pending/spec/disk/modules/raw_disk_spec.rb
@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 require 'ostruct'
 require 'disk/MiqDisk'
 require 'disk/modules/RawDisk'

diff --git a/gems/pending/spec/metadata/MIQExtract/MIQExtract_spec.rb b/gems/pending/spec/metadata/MIQExtract/MIQExtract_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'metadata/MIQExtract/MIQExtract'
 
 describe MIQExtract do

diff --git a/gems/pending/spec/metadata/VmConfig/VmConfig_spec.rb b/gems/pending/spec/metadata/VmConfig/VmConfig_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'metadata/VmConfig/VmConfig'
 
 describe VmConfig do

diff --git a/gems/pending/spec/metadata/linux/LinuxUtils_spec.rb b/gems/pending/spec/metadata/linux/LinuxUtils_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'metadata/linux/LinuxUtils'
 
 describe MiqLinux::Utils do

diff --git a/gems/pending/spec/openstack/amqp/openstack_rabbit_event_monitor_spec.rb b/gems/pending/spec/openstack/amqp/openstack_rabbit_event_monitor_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'openstack/amqp/openstack_rabbit_event_monitor'
 
 describe OpenstackRabbitEventMonitor do

diff --git a/gems/pending/spec/openstack/openstack_event_monitor_spec.rb b/gems/pending/spec/openstack/openstack_event_monitor_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'openstack/openstack_event_monitor'
 require 'openstack/amqp/openstack_rabbit_event_monitor'
 

diff --git a/gems/pending/spec/openstack/openstack_handle/handle_spec.rb b/gems/pending/spec/openstack/openstack_handle/handle_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'openstack/openstack_handle/handle'
 require 'fog/openstack'
 

diff --git a/gems/pending/spec/util/duplicate_blocker_spec.rb b/gems/pending/spec/util/duplicate_blocker_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "logger"
 require "util/duplicate_blocker"
 require "timecop"

diff --git a/gems/pending/spec/util/extensions/miq-array_spec.rb b/gems/pending/spec/util/extensions/miq-array_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-string'
 require 'util/extensions/miq-array'
 

diff --git a/gems/pending/spec/util/extensions/miq-benchmark_spec.rb b/gems/pending/spec/util/extensions/miq-benchmark_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-benchmark'
 require 'timecop'
 

diff --git a/gems/pending/spec/util/extensions/miq-deep_spec.rb b/gems/pending/spec/util/extensions/miq-deep_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-deep'
 
 describe 'miq-deep' do

diff --git a/gems/pending/spec/util/extensions/miq-erb_for_yaml_spec.rb b/gems/pending/spec/util/extensions/miq-erb_for_yaml_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-erb_for_yaml'
 
 describe MiqERBForYAML do

diff --git a/gems/pending/spec/util/extensions/miq-hash_spec.rb b/gems/pending/spec/util/extensions/miq-hash_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-hash'
 
 # Subclass of String to test []= substring complex key patch

diff --git a/gems/pending/spec/util/extensions/miq-kernel_spec.rb b/gems/pending/spec/util/extensions/miq-kernel_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-kernel'
 
 describe Kernel do

diff --git a/gems/pending/spec/util/extensions/miq-module_spec.rb b/gems/pending/spec/util/extensions/miq-module_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-module'
 require 'timecop'
 

diff --git a/gems/pending/spec/util/extensions/miq-numeric_spec.rb b/gems/pending/spec/util/extensions/miq-numeric_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-numeric'
 
 describe Numeric do

diff --git a/gems/pending/spec/util/extensions/miq-object_spec.rb b/gems/pending/spec/util/extensions/miq-object_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-object'
 
 describe Object do

diff --git a/gems/pending/spec/util/extensions/miq-range_spec.rb b/gems/pending/spec/util/extensions/miq-range_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-range'
 
 describe Range do

diff --git a/gems/pending/spec/util/extensions/miq-symbol_spec.rb b/gems/pending/spec/util/extensions/miq-symbol_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-symbol'
 
 describe Symbol do

diff --git a/gems/pending/spec/util/extensions/miq-to_i_with_method_spec.rb b/gems/pending/spec/util/extensions/miq-to_i_with_method_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-to_i_with_method'
 require 'active_support/core_ext/numeric'
 

diff --git a/gems/pending/spec/util/extensions/miq-yaml_spec.rb b/gems/pending/spec/util/extensions/miq-yaml_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/extensions/miq-yaml'
 
 # Subclass of Hash to test instance variables support patch

diff --git a/gems/pending/spec/util/miq-encode_spec.rb b/gems/pending/spec/util/miq-encode_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq-encode'
 
 describe MIQEncode do

diff --git a/gems/pending/spec/util/miq-hash_struct_spec.rb b/gems/pending/spec/util/miq-hash_struct_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq-hash_struct'
 
 describe MiqHashStruct do

diff --git a/gems/pending/spec/util/miq-ipmi_spec.rb b/gems/pending/spec/util/miq-ipmi_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "util/miq-ipmi"
 
 describe MiqIPMI do

diff --git a/gems/pending/spec/util/miq-password_spec.rb b/gems/pending/spec/util/miq-password_spec.rb
@@ -1,6 +1,5 @@
 # encoding: utf-8
 
-require "spec_helper"
 require 'util/miq-password'
 require 'tempfile'
 

diff --git a/gems/pending/spec/util/miq-syntax-checker_spec.rb b/gems/pending/spec/util/miq-syntax-checker_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq-syntax-checker'
 require 'util/extensions/miq-string'
 

diff --git a/gems/pending/spec/util/miq-system_spec.rb b/gems/pending/spec/util/miq-system_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq-system'
 
 describe MiqSystem do

diff --git a/gems/pending/spec/util/miq-unicode_spec.rb b/gems/pending/spec/util/miq-unicode_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq-unicode'
 
 describe 'miq-unicode' do

diff --git a/gems/pending/spec/util/miq-uuid_spec.rb b/gems/pending/spec/util/miq-uuid_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq-uuid'
 
 describe MiqUUID do

diff --git a/gems/pending/spec/util/miq_apache/conf_spec.rb b/gems/pending/spec/util/miq_apache/conf_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq_apache'
 
 describe MiqApache::Conf do

diff --git a/gems/pending/spec/util/miq_apache/control_spec.rb b/gems/pending/spec/util/miq_apache/control_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 describe MiqApache::Control do
   it "should run_apache_cmd with start when calling start" do
     expect(MiqApache::Control).to receive(:run_apache_cmd).with('start')

diff --git a/gems/pending/spec/util/miq_logger_processor_spec.rb b/gems/pending/spec/util/miq_logger_processor_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/miq_logger_processor'
 
 describe MiqLoggerProcessor do

diff --git a/gems/pending/spec/util/miq_ssh_util_v2_spec.rb b/gems/pending/spec/util/miq_ssh_util_v2_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/MiqSshUtilV2'
 
 describe MiqSshUtil do

diff --git a/gems/pending/spec/util/mount/miq_generic_mount_session_spec.rb b/gems/pending/spec/util/mount/miq_generic_mount_session_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "util/mount/miq_generic_mount_session"
 
 describe MiqGenericMountSession do

diff --git a/gems/pending/spec/util/postgres_admin_spec.rb b/gems/pending/spec/util/postgres_admin_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "util/postgres_admin"
 
 describe PostgresAdmin do

diff --git a/gems/pending/spec/util/system/evm_watchdog_spec.rb b/gems/pending/spec/util/system/evm_watchdog_spec.rb
@@ -1,6 +1,5 @@
 # encoding: utf-8
 
-require "spec_helper"
 require 'util/system/evm_watchdog'
 
 describe EvmWatchdog do

diff --git a/gems/pending/spec/util/vmdb-logger_spec.rb b/gems/pending/spec/util/vmdb-logger_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/vmdb-logger'
 
 describe VMDBLogger do

diff --git a/gems/pending/spec/util/win32/miq-powershell_spec.rb b/gems/pending/spec/util/win32/miq-powershell_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'util/win32/miq-powershell'
 require 'time'
 

diff --git a/gems/pending/spec/util/win32/wim_parser_spec.rb b/gems/pending/spec/util/win32/wim_parser_spec.rb
@@ -1,6 +1,5 @@
 # encoding: US-ASCII
 
-require "spec_helper"
 require 'util/win32/wim_parser'
 require 'time'
 

diff --git a/gems/pending/spec/util/xml/miq_rexml_spec.rb b/gems/pending/spec/util/xml/miq_rexml_spec.rb
@@ -1,6 +1,5 @@
 # encoding: UTF-8
 
-require "spec_helper"
 require 'util/miq-xml'
 
 describe MIQRexml do

diff --git a/gems/pending/spec/vmware/esx_thumb_print_spec.rb b/gems/pending/spec/vmware/esx_thumb_print_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require 'vmware/esx_thumb_print'
 require 'vmware/vcenter_thumb_print'
 

diff --git a/spec/automation/unit/engine_validation/miq_ae_state_machine_multi_spec.rb b/spec/automation/unit/engine_validation/miq_ae_state_machine_multi_spec.rb
@@ -1,4 +1,3 @@
-require "spec_helper"
 require "timecop"
 include AutomationSpecHelper
 

diff --git a/spec/automation/unit/engine_validation/miq_ae_state_machine_retry_spec.rb b/spec/automation/unit/engine_validation/miq_ae_state_machine_retry_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 describe "MiqAeStateMachineRetry" do
   before do
     @method_name     = 'MY_RETRY_METHOD'

diff --git a/spec/automation/unit/engine_validation/miq_ae_state_machine_steps_spec.rb b/spec/automation/unit/engine_validation/miq_ae_state_machine_steps_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 describe "MiqAeStateMachineSteps" do
   before do
     @user                = FactoryGirl.create(:user_with_group)

diff --git a/spec/automation/unit/method_validation/amazon_auto_placement_spec.rb b/spec/automation/unit/method_validation/amazon_auto_placement_spec.rb
@@ -1,5 +1,3 @@
-require "spec_helper"
-
 describe "AMAZON best fit" do
 
   let(:user) { FactoryGirl.create(:user_with_group) }