Skip to content

Commit

Permalink
PR Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mkanoor committed Jan 11, 2017
1 parent e6bff3a commit 18c82f1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def process_args_attribute(args, args_key)
key, klass = get_key_name_and_klass_from_key(args_key)
value = args.delete(args_key)
args["#{key}_id"] = value unless @attributes.key?(key)
args[key.downcase] = MiqAeObject.convert_value_based_on_datatype(value, klass)
args[key] = MiqAeObject.convert_value_based_on_datatype(value, klass)
else
args[args_key.downcase] = args.delete(args_key) if args_key != args_key.downcase
end
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/miq_automation_engine/miq_ae_object_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ def value_match(value, xml_value)
"Name" => "fred")
expect(result["vms"]).to be_kind_of(Array)
expect(result["vms"].length).to eq(1)
expect(result["VMs"]).to be_nil
expect(result["name"]).to eq("fred")
expect(result["Name"]).to be_nil
expect(result["VMs"]).to be_nil
end

it "#process_args_as_attributes with an array" do
Expand Down

0 comments on commit 18c82f1

Please sign in to comment.