Upgrade Ruby to 3.3 and Jekyll to 4.3 #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
added
enhancement
dependencies
Fryguy
force-pushed
the
upgrade_jekyll_ruby
branch
from
7a0ab3d to
102979f
Compare
Jekyll comes with the jekyll-sass-converter plugin, so most of the work in this commit is switching to that gem, which expects an _sass directory by default. Also, that gem does not support sprockets, so we need to do some manual handling of the various sass gems to include their stylesheets and other assets (fonts) in the proper directories. Fixes ManageIQ#878
Fryguy
force-pushed
the
upgrade_jekyll_ruby
branch
from
102979f to
b00bde9
Compare
jrafanie
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Awesome! 2.7 to 3.3 is quite a jump.
This looks great. For followup, does it make sense to checkin a Gemfile.lock for this project? I know some of them were created before Gemfile.lock worked well cross-platform so maybe that's why we don't have it. Just a thought. Not sure if it makes sense.
Fryguy
added a commit
to Fryguy/manageiq-documentation
that referenced
this pull request
Dec 19, 2024
Fryguy
added a commit
to Fryguy/guides
that referenced
this pull request
Dec 19, 2024
Follow up to ManageIQ/manageiq.org#1192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jekyll comes with the jekyll-sass-converter plugin, so most of the work in this commit is switching to that gem, which expects an _sass directory by default. Also, that gem does not support sprockets, so we need to do some manual handling of the various sass gems to include their stylesheets and other assets (fonts) in the proper directories.
Fixes #878
@jrafanie Please review.
This should also end up closing some renovate PRs