Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

[#607] Make OSP Instance Properties step compatible with Edit Plan and enable Edit Plan #674

Merged
merged 3 commits into from
Oct 1, 2018
Merged

[#607] Make OSP Instance Properties step compatible with Edit Plan and enable Edit Plan #674

merged 3 commits into from
Oct 1, 2018

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Sep 28, 2018 •
edited
Loading

Closes #607 🎉

@mturley mturley mentioned this pull request Oct 1, 2018
Closed
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commits mturley/manageiq-v2v@2ba58df~...1f980d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mturley mturley changed the title Make OSP Instance Properties step compatible with Edit Plan feature [#607] Make OSP Instance Properties step compatible with Edit Plan feature Oct 1, 2018
@mturley mturley changed the title [#607] Make OSP Instance Properties step compatible with Edit Plan feature [#607] Make OSP Instance Properties step compatible with Edit Plan and enable Edit Plan Oct 1, 2018
AparnaKarve
AparnaKarve approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@AparnaKarve AparnaKarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Verified that the OSP Instance Properties step works well in Edit Plan.

Thanks @mturley !

@AparnaKarve
Copy link
Contributor

@mturley As a follow-up on Edit Plan, can we implement the logic where if the before and after POST body looks identical for a Plan, then we should not make the API call for editing a Plan.

This has been implemented for Infra mappings, hence would be nice to implement it here as well.
(Not a high priority requirement though)

@AparnaKarve AparnaKarve merged commit 5d83487 into ManageIQ:master Oct 1, 2018
@mturley mturley deleted the edit-osp-plan branch October 1, 2018 19:17
@mturley mturley mentioned this pull request Oct 1, 2018
Closed
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@AparnaKarve @simaishi
Merge pull request #674 from mturley/edit-osp-plan
6ffabb6 
[#607] Make OSP Instance Properties step compatible with Edit Plan and enable Edit Plan

(cherry picked from commit 5d83487)
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit 6ffabb698147a2784eb6d88789c5b7584a16d6df
Author: Aparna Karve <[email protected]>
Date:   Mon Oct 1 12:17:19 2018 -0700

    Merge pull request #674 from mturley/edit-osp-plan
    
    [#607] Make OSP Instance Properties step compatible with Edit Plan and enable Edit Plan
    
    (cherry picked from commit 5d8348715efb5992fcbdb03f825c446caf8e348e)

@vconzola vconzola mentioned this pull request Oct 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AparnaKarve AparnaKarve AparnaKarve approved these changes

@michaelkro michaelkro Awaiting requested review from michaelkro

Assignees
No one assigned
Labels
hammer/backported Sprint 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mturley @miq-bot @AparnaKarve @simaishi