This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Remove dead V2V_EDIT_PLAN_TITLE_SHOW_ALERT V2V_EDIT_PLAN_TITLE_HIDE_ALERT #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LERT looks like they were introduced in #663, but the last commit of that PR (1b79249) removes these from all but this one place. (With new babel, this produces a warning: "export 'V2V_EDIT_PLAN_TITLE_HIDE_ALERT' was not found in './EditPlanNameConstants' "export 'V2V_EDIT_PLAN_TITLE_SHOW_ALERT' was not found in './EditPlanNameConstants' )
|
Checked commit https://github.com/himdel/manageiq-v2v/commit/1b4f1339f97a012f66806ac34a9fd31e986cdff7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Sep 18, 2019
|
Good catch, thanks @himdel ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @mturley , @mzazrivec
Looks like these were introduced in #663,
but the last commit of that PR (1b79249) removes these from all but this one place.
(With new babel, this produces a warning:
)