Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1469802 - Buttons are updated on power operations, but don't disappear #844

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jul 12, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1469802
https://www.pivotaltracker.com/story/show/148785143

Original intent appeared to be, after taking power option on a service, the buttons might change. getlistActions() doesn't return anything, so the assignment of that function to the button array was kinda... no bueno...

Buttons are updated on power operations, but don't disappear

customdropdown

getlistActions() doesn't return anything...
@AllenBW AllenBW added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 12, 2017
@AllenBW AllenBW requested a review from chriskacerguis as a code owner July 12, 2017 19:37
@AllenBW AllenBW changed the title Buttons are updated on power operations, but don't disappear BZ#1469802 - Buttons are updated on power operations, but don't disappear Jul 12, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2017

Checked commit AllenBW@704cffc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chriskacerguis chriskacerguis merged commit 84daf59 into ManageIQ:master Jul 12, 2017
@AllenBW AllenBW deleted the BZ/#148785143-disapearing-custom-dropdowns branch July 17, 2017 14:50
simaishi pushed a commit that referenced this pull request Aug 4, 2017
…-dropdowns

BZ#1469802 - Buttons are updated on power operations, but don't disappear
(cherry picked from commit 84daf59)

https://bugzilla.redhat.com/show_bug.cgi?id=1478542
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit 546ee01f6c3fb1b9553f621eb1bd9063ea2e3619
Author: Chris Kacerguis <[email protected]>
Date:   Wed Jul 12 15:47:19 2017 -0400

    Merge pull request #844 from AllenBW/BZ/#148785143-disapearing-custom-dropdowns
    
    BZ#1469802 - Buttons are updated on power operations, but don't disappear
    (cherry picked from commit 84daf591a9f92476fdd43f25793843a2814e78ed)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants