BZ#1460316 - Ensure action target collection matches button class #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also addresses issue of inactionable error message
|
Checked commits AllenBW/manageiq-ui-service@c303177~...1deb7f7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Jul 7, 2017
simaishi
pushed a commit
that referenced
this pull request
Jul 7, 2017
BZ#1460316 - Ensure action target collection matches button class (cherry picked from commit b310615) https://bugzilla.redhat.com/show_bug.cgi?id=1460316
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/148493525
https://bugzilla.redhat.com/show_bug.cgi?id=1460316
Also addresses issue of inactionable error message
👀 👍 🌮 first, look meaningful error! second, look custom service and custom vm actions working!
@imtayadeway @chalettu @jntullo ya'll effin' rock, thanks for laying the groundwork for this quick fix!