Unify console names between ops & service UI - VM Console & Web Console #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/himdel/manageiq-ui-service/commit/50a102f5c42f42b88446f2de47cd1424e8ab554c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I don't think that will close that PT. I think this is more a stop gap for that issue. |
|
@chriskacerguis oh? do tell! What else is needed to close it? |
|
Changing to |
|
@AllenBW the story that you presented was to make the design like UXD's proposed design: https://github.com/cockpit-project/cockpit/wiki/Product-Integration |
simaishi
pushed a commit
that referenced
this pull request
Jun 15, 2017
Unify console names between ops & service UI - VM Console & Web Console (cherry picked from commit 077ec15) https://bugzilla.redhat.com/show_bug.cgi?id=1441321
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the discussion in https://bugzilla.redhat.com/show_bug.cgi?id=1441321 and ManageIQ/manageiq-ui-classic#1429 - see details there.
But, per Cockpit intergration guidelines, "Cockpit Console" should be named "Web Console".
I'm also chaning the button from "Open * Console" to "* Console" for consistency with Ops UI.
https://bugzilla.redhat.com/show_bug.cgi?id=1441321
Cc @chriskacerguis, @Loicavenel