Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for a vm to submit a custom button action #791

Merged
merged 1 commit into from
May 25, 2017
Merged

Added support for a vm to submit a custom button action #791

merged 1 commit into from
May 25, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu changed the title added support for a vm to submit a custom button action Added support for a vm to submit a custom button action May 24, 2017
@chalettu
Copy link
Contributor Author

@miq-bot add_label bug
@miq-bot add_label fine/yes
@miq-bot add_label my services / details

@miq-bot
Copy link
Member

miq-bot commented May 24, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/384271f27967cd8936870d688e5465348f075728 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@chriskacerguis
Copy link
Contributor

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1454910

@chriskacerguis chriskacerguis self-assigned this May 24, 2017
@chriskacerguis chriskacerguis requested a review from AllenBW May 24, 2017 21:16
@chriskacerguis chriskacerguis added this to the Sprint 62 Ending Jun 5, 2017 milestone May 24, 2017
AllenBW
AllenBW approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 💃

@chriskacerguis chriskacerguis merged commit 9860bdc into ManageIQ:master May 25, 2017
simaishi pushed a commit that referenced this pull request Jun 9, 2017
@chriskacerguis @simaishi
Merge pull request #791 from chalettu/vm-custom-button-actions
2663f3b 
Added support for a vm to submit a custom button action
(cherry picked from commit 9860bdc)

https://bugzilla.redhat.com/show_bug.cgi?id=1460316
@simaishi
Copy link
Contributor

simaishi commented Jun 9, 2017

Fine backport details:

$ git log -1
commit 2663f3b2df17f99ccf17cb3874ce591248559242
Author: Chris Kacerguis <[email protected]>
Date:   Thu May 25 09:47:37 2017 -0500

    Merge pull request #791 from chalettu/vm-custom-button-actions
    
    Added support for a vm to submit a custom button action
    (cherry picked from commit 9860bdc1093adbb452b386a19eed98b38bfe9aec)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460316

@chalettu chalettu deleted the vm-custom-button-actions branch September 27, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

@chriskacerguis chriskacerguis chriskacerguis approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalettu @miq-bot @chriskacerguis @simaishi @AllenBW