Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending string true vs literal true #771

Merged
merged 1 commit into from
May 17, 2017
Merged

sending string true vs literal true #771

merged 1 commit into from
May 17, 2017

Conversation

chriskacerguis
Copy link
Contributor

@chriskacerguis chriskacerguis commented May 17, 2017

sending string true vs literal true

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1435459

@chriskacerguis chriskacerguis added this to the Sprint 61 Ending May 22, 2017 milestone May 17, 2017
@miq-bot
Copy link
Member

miq-bot commented May 17, 2017

Checked commit https://github.com/chriskacerguis/manageiq-ui-service/commit/dd5af3974c6251725425136c7efe8b1743669678 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 💃

@chriskacerguis
Copy link
Contributor Author

@AllenBW can you merge?

@AllenBW AllenBW merged commit 21de7ce into ManageIQ:master May 17, 2017
simaishi pushed a commit that referenced this pull request May 17, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 94cbabc50b4326da13843951f493cc62f14b40cf
Author: Allen Wight <[email protected]>
Date:   Wed May 17 09:38:19 2017 -0400

    Merge pull request #771 from chriskacerguis/master
    
    sending string true vs literal true
    (cherry picked from commit 21de7ce2efaf9ace43df55d25e13de2305d62a83)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants