Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT#141308069-Refactor services state for clarity and uniformity #575

Merged

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Mar 10, 2017

This pr:

  • refactors services state service to better align with existing service (and functionality) by removing resource fetching from the details state resolve
  • updates service-explorer to use refactored services state
  • updates tests for component controller changes (though one needs to be revisted)
  • adds ansible details
  • adds elapsedTime filter
  • addresses a bug where action buttons weren't hiding on type ServiceAnsiblePlaybook
  • refactors service-details controller for clarity/conciseness

https://www.pivotaltracker.com/story/show/141308069
only part of ☝️ is addressed, the second stage is still blocked by outstanding pr

look not much changes!

image

an ansible service playbook

image

(this image, i had to scroll a bit to grab the last part)

@AllenBW AllenBW added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 10, 2017
@chriskacerguis chriskacerguis self-assigned this Mar 10, 2017
@chriskacerguis
Copy link
Contributor

@AllenBW travis no like you today.

Pruned service details componet test bloat
@AllenBW AllenBW added the wip label Mar 10, 2017
@AllenBW AllenBW changed the title PT#141308069-Refactor services state for clarity and uniformity [WIP]PT#141308069-Refactor services state for clarity and uniformity Mar 10, 2017
Accepts a value in seceonds, displays 00 hours 00 min 00 sec
@AllenBW AllenBW changed the title [WIP]PT#141308069-Refactor services state for clarity and uniformity PT#141308069-Refactor services state for clarity and uniformity Mar 10, 2017
@AllenBW AllenBW removed the wip label Mar 10, 2017
Increases polling duration for this view
@AllenBW AllenBW force-pushed the enhancement/141308069-ansible-details branch from 12c2796 to de0cdce Compare March 10, 2017 19:33
@miq-bot
Copy link
Member

miq-bot commented Mar 10, 2017

Checked commits AllenBW/manageiq-ui-service@a62fbdc~...de0cdce with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@chriskacerguis chriskacerguis merged commit a7ce52a into ManageIQ:master Mar 10, 2017
@AllenBW AllenBW deleted the enhancement/141308069-ansible-details branch March 13, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants