Session - use localStorage instead of sessionStorage #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sessionStorage is not shared between tabs (unless one gets opened from the other), and disappears when closing the tab the same change was needed in ui-classic: ManageIQ/manageiq-ui-classic#3065 The one place that's still using sessionStorage after this is the ApplianceInfo service, for caching. That looks more like ephemeral cache which doesn't have to be shared.
miq-bot
changed the title
|
@miq-bot remove_label wip It works, opening /services/80 in a new tab no longer redirects to /login. |
miq-bot
changed the title
|
Checked commit https://github.com/himdel/manageiq-ui-service/commit/554ef42d698c1ad3f5f296de83c4bce96fbaa532 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionStorage is not shared between tabs (unless one gets opened from the other),
and disappears when closing the tab.
Thus, opening a link in a new tab just doesn't work and redirects to
/login.Changing to use localStorage instead - the same change was needed in ui-classic: ManageIQ/manageiq-ui-classic#3065
The one place that's still using sessionStorage after this is the ApplianceInfo service, for caching. That looks more like ephemeral cache which doesn't have to be shared.
Fixes #1527