Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the VM remote console button to the new unified HTML5 console #1553

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Update the VM remote console button to the new unified HTML5 console #1553

merged 1 commit into from
Jul 17, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 1, 2019 •
edited
Loading

In order to support webmks here, there were some changes in the backend for the new HTML5 console meta type. This PR adjusts the codebase to these changes.

Depends on: ManageIQ/manageiq#18927 and ManageIQ/manageiq-api#621

https://bugzilla.redhat.com/show_bug.cgi?id=1532720

@skateman skateman changed the title [WIP] Support for WebMKS remote consoles [WIP] Update the VM remote console button to the new unified HTML5 console Jul 1, 2019
@skateman
Copy link
Member Author

skateman commented Jul 1, 2019

@miq-bot add_reviewer @himdel
@miq-bot add_label enhancement, hammer/no, changelog/yes

@miq-bot miq-bot requested a review from himdel July 1, 2019 20:57
@skateman skateman changed the title [WIP] Update the VM remote console button to the new unified HTML5 console Update the VM remote console button to the new unified HTML5 console Jul 2, 2019
@skateman skateman changed the title Update the VM remote console button to the new unified HTML5 console [WIP] Update the VM remote console button to the new unified HTML5 console Jul 2, 2019
@skateman skateman changed the title [WIP] Update the VM remote console button to the new unified HTML5 console Update the VM remote console button to the new unified HTML5 console Jul 2, 2019
@skateman skateman mentioned this pull request Jul 2, 2019
Merged
@miq-bot
Copy link
Member

miq-bot commented Jul 4, 2019

Checked commit skateman@c8fbe80 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@himdel
Copy link
Contributor

himdel commented Jul 17, 2019

LGTM, I've seen this work (both vnc and mks) :)
(Waiting for core)

@himdel himdel closed this Jul 17, 2019
@himdel himdel reopened this Jul 17, 2019
@himdel himdel self-assigned this Jul 17, 2019
@himdel himdel merged commit 1580c55 into ManageIQ:master Jul 17, 2019
@himdel himdel added this to the Sprint 116 Ending Jul 22, 2019 milestone Jul 17, 2019
@skateman skateman deleted the html5-console branch July 17, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees

@himdel himdel

Labels
changelog/yes enhancement hammer/no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skateman @miq-bot @himdel