Service detail screen - don't run automate methods #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(whitespace/comma change only)
…ions object so we can have more options
Asking the API for `provision_dialog` evaluates any automate methods it needs to populate the dialog data. That's not always desirable, parametrizing. https://bugzilla.redhat.com/show_bug.cgi?id=1695804
|
@h-kataria , @AllenBW please take a look? :) |
|
Checked commits https://github.com/himdel/manageiq-ui-service/compare/c3c44e32e250df9593c304006d590bdc1322120e~...1466c421ea4d9ddc35927024392ff5e7ff6d345d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
AllenBW
approved these changes
Jul 10, 2019
simaishi
pushed a commit
that referenced
this pull request
Oct 4, 2019
Service detail screen - don't run automate methods (cherry picked from commit 0c37f06) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1755393
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying the service detail screen (
/services/:id), we're doing an API request for the details, includingprovision_dialog.But, computing
provision_dialogevaluates all the automate methods,which is not useful when we don't display the dialog afterwards.
=> Added a
runAutomateoption togetService, and set it to false when on the screen.(Ops-side, this was solved in ManageIQ/manageiq-ui-classic#5126, by reimplementing a readonly part of dialog-user to display the fields with values from
options. SUI-side, I'm not seeing the dialog being displayed, so no need for that.)Cc @eclarizio
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1695804