Timeline - remove onResize handler when destroying timeline #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1337 The timeline component listens for the resize event on window, and triggers a repaint of the timeline But, it never removes that listener, even after moving to a screen without timeline, causing a console error when opening the notification area (which generates a resize event). Error: <rect> attribute width: A negative value is not valid. ("-250") Error: <pattern> attribute width: A negative value is not valid. ("-250") Error: <rect> attribute width: A negative value is not valid. ("-250") Error: <rect> attribute width: A negative value is not valid. ("-250") This fixes that, by removing the listener when the component is destroyed.
|
Steps to reproduce: Go to My Services Before: errors in js console |
|
Checked commit https://github.com/himdel/manageiq-ui-service/commit/5b2d58e6afdc2474df3103d9682e62b51477df15 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1337
The timeline component listens for the resize event on window, and triggers a repaint of the timeline
But, it never removes that listener, even after moving to a screen without timeline,
causing a console error when opening the notification area (which generates a resize event).
This fixes that, by removing the listener when the component is destroyed.
Cc @AllenBW , no more 1337 issues, w00t :)