Adds on-close to pf-notification-drawer component #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @serenamarie125 yah ok with this change? |
|
Checked commit AllenBW@3f820b8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
hmmm @AllenBW there are responsive states for the notification drawer in PF ... http://www.patternfly.org/pattern-library/communication/notification-drawer/
- the drawer should always have an "X" ( I think this was a recent addition )
- but check out the responsive nature in the code example above
What's the change you made here, just adding the "X" ?
|
@serenamarie125 Yep ! just adding it, didn't know it was a recent change! why yah were tagged in, goooood to know 👍 |
serenamarie125
approved these changes
Apr 2, 2018
There was a problem hiding this comment.
@AllenBW I guess great minds think alike. Thank you for the "X" 👍
|
@miq-bot add_labels ux/approved |
|
@miq-bot remove_labels ux/review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://bugzilla.redhat.com/show_bug.cgi?id=1554809
does not modify default behavior of clicking the bell to open and close tray
So we have this real narrow edge case of 20-30 pixels where yah can end up with this view:
In efforts to avoid this purgatory, unable to close notifications, proposing we do this, add a notification list close button (what this pr does):