Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes disk size misreporting for some disks #1410

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Mar 21, 2018

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561160
(Resource details view) Some disks total size was being misreported in the tooltip.

before

screen shot 2018-03-21 at 8 34 40 am

after

screen shot 2018-03-21 at 8 34 09 am

@AllenBW
Copy link
Member Author

AllenBW commented Mar 21, 2018

cc @nachandr 🙇 ❤️ 🎿

@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2018

Checked commit AllenBW@7bccb79 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (Dammit github)

@himdel himdel merged commit 8090f4e into ManageIQ:master Apr 5, 2018
@himdel himdel added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 5, 2018
@AllenBW AllenBW deleted the bug/resource-details-misreporting-cd-diskspace branch April 5, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants