Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UI components version to remedy dialog select issue #1383

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Updated UI components version to remedy dialog select issue #1383

merged 1 commit into from
Feb 13, 2018

Conversation

chalettu
Copy link
Contributor

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 12, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/e0f7c8a533c2ec19014fed621579ee0498c534f7 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@chalettu
Copy link
Contributor Author

@himdel , could you review this one for me? This is to mirror the update that was made in ui-components

@AllenBW AllenBW self-assigned this Feb 13, 2018
@AllenBW AllenBW self-requested a review February 13, 2018 12:56
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AllenBW AllenBW merged commit 2ee001e into ManageIQ:master Feb 13, 2018
@AllenBW
Copy link
Member

AllenBW commented Feb 13, 2018

@chalettu is this a blocker? I didn't see a bz attached 🤔

@chalettu
Copy link
Contributor Author

This is our mirror fix for https://bugzilla.redhat.com/show_bug.cgi?id=1531316

@AllenBW
Copy link
Member

AllenBW commented Feb 15, 2018

soooo yep, blocker! awesome, thanks for linking!

simaishi pushed a commit that referenced this pull request Feb 15, 2018
Updated UI components version to remedy dialog select issue
(cherry picked from commit 2ee001e)

https://bugzilla.redhat.com/show_bug.cgi?id=1531316
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 53e1d03bbbd3fd443988a4387ad52044e18df5d9
Author: Allen Wight <[email protected]>
Date:   Tue Feb 13 07:57:38 2018 -0500

    Merge pull request #1383 from chalettu/dialog-select-ui-components
    
    Updated UI components version to remedy dialog select issue
    (cherry picked from commit 2ee001eb3df3a646666126e14595fba8d471c782)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants