Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep ui-components in sync with classic #1369

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Keep ui-components in sync with classic #1369

merged 1 commit into from
Jan 23, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jan 23, 2018 •
edited
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1536528

☝️ Related bz, doesn't fix this one (cuz the ui-components update in classic does), but this work is related to that bz

@AllenBW AllenBW requested a review from himdel as a code owner January 23, 2018 12:56
@AllenBW AllenBW added the bug label Jan 23, 2018
@AllenBW AllenBW added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 23, 2018
@simaishi simaishi assigned himdel and unassigned simaishi Jan 23, 2018
@simaishi
Copy link
Contributor

Although not a blocker, I've added blocker label so I won't forget to backport this - we want to keep ui-components in sync.

@AllenBW AllenBW force-pushed the BZ/MASTER/#1536528-ui-components branch from e1c9d96 to 5ed3fee Compare January 23, 2018 14:14
himdel
himdel reviewed Jan 23, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 matches ManageIQ/manageiq-ui-classic#3304 :)

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2018

Checked commit AllenBW@5ed3fee with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

himdel
himdel approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...because comment is not an approval, gah!

@himdel himdel merged commit 893fa81 into ManageIQ:master Jan 23, 2018
@AllenBW AllenBW deleted the BZ/MASTER/#1536528-ui-components branch January 23, 2018 14:39
simaishi pushed a commit that referenced this pull request Jan 23, 2018
@himdel @simaishi
Merge pull request #1369 from AllenBW/BZ/MASTER/#1536528-ui-components
559cdad 
Keep ui-components in sync with classic
(cherry picked from commit 893fa81)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 559cdad6921af392f1422f1c63ca3f6cdd6f96ae
Author: Martin Hradil <[email protected]>
Date:   Tue Jan 23 15:24:34 2018 +0100

    Merge pull request #1369 from AllenBW/BZ/MASTER/#1536528-ui-components
    
    Keep ui-components in sync with classic
    (cherry picked from commit 893fa81c7bec874fa389ef14894f0124466e05a5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees

@himdel himdel

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AllenBW @simaishi @miq-bot @himdel