Reorders when service catalog filter is built #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536385 Async fun! Looks like we were building the filter before we had what we needed, now we wait.
|
Checked commit AllenBW@4fffefb with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
LGTM, timing bugs are always fun, make sense 👍
(Tested in the ui with client/app/catalogs/catalogs-state.service.js:79
- attributes: ['picture', 'picture.image_href', 'service_template_catalog'],
+ attributes: ['service_template_catalog'],to work around a current API bug.)
simaishi
pushed a commit
that referenced
this pull request
Jan 19, 2018
…log-fail Reorders when service catalog filter is built (cherry picked from commit 6f472c5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536608
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536385
Async fun! Looks like we were building the filter before we had what we needed, now we wait.
oooo it works now!