Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch new users (group) authorizations rather than loading from session storage #1363

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Fetch new users (group) authorizations rather than loading from session storage #1363

merged 1 commit into from
Jan 19, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jan 18, 2018 •
edited
Loading

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536124

Also sends user to dashboard, else they get stuck on a page they shouldn't be on and get pummled with errors

what this pr does

rbac

@AllenBW
Gets new user authorizations rather than loads user on group change
4053183 
Also sends user to dashboard, else they get stuck on a page they shouldn't be on and get pummled with errors
@AllenBW AllenBW requested a review from himdel as a code owner January 18, 2018 16:37
@AllenBW AllenBW added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 18, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2018

Checked commit AllenBW@4053183 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@AllenBW AllenBW changed the title Fetches new user (group) authorizations rather than loading from session storage Fetch new users (group) authorizations rather than loading from session storage Jan 18, 2018
chalettu
chalettu approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@chalettu chalettu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid change. Good work!

himdel
himdel approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the code path looks good and the UI does seem to reload properly 👍

@himdel himdel merged commit 09f39ad into ManageIQ:master Jan 19, 2018
@AllenBW AllenBW deleted the bug/master/#1536124-rbac-group-switch-update branch January 19, 2018 13:00
simaishi pushed a commit that referenced this pull request Jan 19, 2018
@himdel @simaishi
Merge pull request #1363 from AllenBW/bug/master/#1536124-rbac-group-…
bb8b8c2 
…switch-update

Fetch new users (group) authorizations rather than loading from session storage
(cherry picked from commit 09f39ad)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536468
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit bb8b8c22a36f89c81a8f9f458f729c2565fef47c
Author: Martin Hradil <[email protected]>
Date:   Fri Jan 19 11:20:17 2018 +0100

    Merge pull request #1363 from AllenBW/bug/master/#1536124-rbac-group-switch-update
    
    Fetch new users (group) authorizations rather than loading from session storage
    (cherry picked from commit 09f39ad814b8c9e68b36727624c89d44615323f9)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536468

@himdel himdel mentioned this pull request Jan 19, 2018
Merged
@AllenBW AllenBW mentioned this pull request Jan 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@chalettu chalettu chalettu approved these changes

Assignees

@himdel himdel

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllenBW @miq-bot @simaishi @chalettu @himdel