Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1516430-Ensure the correct ansible play elapsed time is displayed #1326

Merged
merged 2 commits into from
Dec 12, 2017
+3 −3
Merged

BZ#1516430-Ensure the correct ansible play elapsed time is displayed #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4f27d0
Ensure the correct ansible play elapsed time is displayed
AllenBW Dec 7, 2017
6f8774b
Fix time in resource details view as well
AllenBW Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/app/services/resource-details/resource-details.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ function ComponentController ($state, $stateParams, VmsService, lodash, EventNot
}

function elapsed (finish, start) {
return Math.abs(new Date(finish) - new Date(start)) / 100
return Math.abs(new Date(finish) - new Date(start)) / 1000
}

function availableTooltip (item) {
Expand Down
2 changes: 1 addition & 1 deletion client/app/services/service-details/service-details-ansible.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,6 @@ function ComponentController (ModalService, ServicesState, lodash) {
}

function elapsed (finish, start) {
return Math.abs(new Date(finish) - new Date(start)) / 100
return Math.abs(new Date(finish) - new Date(start)) / 1000
}
}
2 changes: 1 addition & 1 deletion client/app/services/service-details/service-details-ansible.component.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('Component: ServiceDetailsAnsibleComponent', function () {
it('should calculate elapsed time', () => {
ctrl.$onInit()
const elapsedTime = ctrl.elapsed(1497908279, 1497908159)
expect(elapsedTime).to.eq(1.2)
expect(elapsedTime).to.eq(0.12)
})
it('should allow onchanges to be called', (done) => {
const getServiceCredentialSpy = sinon.stub(ServicesState, 'getServiceCredential').returns(Promise.resolve(successResponse))
Expand Down