Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct compliance icon, 7 day timeline, last hour utilization #1284

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Nov 28, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1516807

tl;dr

  • timeline, when empty shows 7 day range, set default timeline option to a 7 day period, this is then updated to better fit the events data
  • compliance icon is now correct, value is capitalized
  • utilization data now grabs the hour behind the latest (where as before it was grabbing the second item in an array), Ends up vm metrics stream sometimes returns two entries per hour, that means we need to find the one from the last hour, hence the .find
  • utilization available number has been truncated to three places

with events in timeline (after)

screen shot 2017-11-28 at 5 39 04 pm

with events in timeline (before)

screen shot 2017-11-28 at 5 47 51 pm


without events in timeline (after)

screen shot 2017-11-28 at 5 38 48 pm

without events in timeline (before) (you'll notice we're missing storage because we were grabbing the wrong hour)

screen shot 2017-11-28 at 5 48 29 pm

@AllenBW AllenBW added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 28, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Nov 28, 2017

cc @Loicavenel lemme know if this satisfies the ask of the bz 🙇‍♀️ ❤️

@AllenBW AllenBW force-pushed the bug/master/#1516807-update-resource-details branch from b56e89f to 4a865b0 Compare November 28, 2017 22:59
Resource details state also now truncates utilization available resources to 3 places Ends up vm metrics stream sometimes returns two entries per hour, that means we need to find the one from the last hour, hence the .find Set default timeline option to a 7 day period, this is then updated to better fit the events data Ensured compliance is capitalized
@AllenBW AllenBW force-pushed the bug/master/#1516807-update-resource-details branch from 4a865b0 to d97b933 Compare November 28, 2017 23:00
@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commit AllenBW@d97b933 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chriskacerguis chriskacerguis self-assigned this Nov 29, 2017
@chriskacerguis chriskacerguis merged commit c60105b into ManageIQ:master Nov 29, 2017
@simaishi
Copy link
Contributor

@AllenBW There is a conflict backporting this to Gaprindashvili for manageiq-ui-service.pot. Normally translation related files are not backported and it has its own branch specific PRs. What should I do with this conflict?

cc @mzazrivec

@AllenBW
Copy link
Member Author

AllenBW commented Nov 29, 2017

@simaishi uggghhh yeah that didn't need to be in this pr, must have missed it, can that file be disregarded and the rest backported?

@AllenBW AllenBW deleted the bug/master/#1516807-update-resource-details branch November 29, 2017 14:47
@mzazrivec
Copy link
Contributor

Changes in manageiq-ui-service.pot should not be backported (i.e. the one already in gaprindashvili
branch should stay as it is).

@simaishi
Copy link
Contributor

OK, will backport the rest.

simaishi pushed a commit that referenced this pull request Nov 29, 2017
…urce-details

Ensure correct compliance icon, 7 day timeline, last hour utilization
(cherry picked from commit c60105b)

https://bugzilla.redhat.com/show_bug.cgi?id=1518748
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d12281acb8ce63bc7511c8cdb01ca3f53a7293bb
Author: Chris Kacerguis <[email protected]>
Date:   Tue Nov 28 19:22:53 2017 -0600

    Merge pull request #1284 from AllenBW/bug/master/#1516807-update-resource-details
    
    Ensure correct compliance icon, 7 day timeline, last hour utilization
    (cherry picked from commit c60105b1dd7f9c862c76e0134bb2b4d176db236b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants