-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure correct compliance icon, 7 day timeline, last hour utilization #1284
Ensure correct compliance icon, 7 day timeline, last hour utilization #1284
Conversation
cc @Loicavenel lemme know if this satisfies the ask of the bz 🙇♀️ ❤️ |
b56e89f
to
4a865b0
Compare
Resource details state also now truncates utilization available resources to 3 places Ends up vm metrics stream sometimes returns two entries per hour, that means we need to find the one from the last hour, hence the .find Set default timeline option to a 7 day period, this is then updated to better fit the events data Ensured compliance is capitalized
4a865b0
to
d97b933
Compare
Checked commit AllenBW@d97b933 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@AllenBW There is a conflict backporting this to Gaprindashvili for cc @mzazrivec |
@simaishi uggghhh yeah that didn't need to be in this pr, must have missed it, can that file be disregarded and the rest backported? |
Changes in |
OK, will backport the rest. |
…urce-details Ensure correct compliance icon, 7 day timeline, last hour utilization (cherry picked from commit c60105b) https://bugzilla.redhat.com/show_bug.cgi?id=1518748
Gaprindashvili backport details:
|
https://bugzilla.redhat.com/show_bug.cgi?id=1516807
tl;dr
with events in timeline (after)
with events in timeline (before)
without events in timeline (after)
without events in timeline (before) (you'll notice we're missing storage because we were grabbing the wrong hour)