Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1471158-Adds support for supports_vnc_console decorator #1195

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Nov 1, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1471158

Waiting for this to make it in: ManageIQ/manageiq-api#167

This pr does NOT fix: https://bugzilla.redhat.com/show_bug.cgi?id=1505546 a separate pr will be required for this

@AllenBW AllenBW added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 1, 2017
@AllenBW AllenBW force-pushed the BZ/#1471158-add-supports-vnc-console-flag branch from 05ce608 to d068caf Compare November 1, 2017 15:54
@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2017

Checked commit AllenBW@d068caf with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@chriskacerguis
Copy link
Contributor

@AllenBW looks like ManageIQ/manageiq-api#167 is merged, I restarted the build on this (Node 6 failed...thinking it is just Travis being Travis). Can this be merged?

@AllenBW
Copy link
Member Author

AllenBW commented Nov 6, 2017

This is good to go! @chriskacerguis

@AllenBW AllenBW removed the wip label Nov 6, 2017
@chriskacerguis chriskacerguis merged commit 3745df5 into ManageIQ:master Nov 6, 2017
@AllenBW AllenBW deleted the BZ/#1471158-add-supports-vnc-console-flag branch November 6, 2017 20:55
simaishi pushed a commit that referenced this pull request Nov 6, 2017
…nsole-flag

BZ#1471158-Adds support for supports_vnc_console decorator
(cherry picked from commit 3745df5)

https://bugzilla.redhat.com/show_bug.cgi?id=1510131
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 2d576999f64558929d9e6da437124a7e91219a2f
Author: Chris Kacerguis <[email protected]>
Date:   Mon Nov 6 07:47:46 2017 -0600

    Merge pull request #1195 from AllenBW/BZ/#1471158-add-supports-vnc-console-flag
    
    BZ#1471158-Adds support for supports_vnc_console decorator
    (cherry picked from commit 3745df59512d1e45cab8dac27836cd58547398e0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

@simaishi
Copy link
Contributor

@AllenBW Please create a separate PR for Fine branch - none of the files are clean cherry-pick...

@AllenBW
Copy link
Member Author

AllenBW commented Nov 27, 2017

@simaishi ok don't wantcha to think i forgot about this, so looks like this work isn't enough to get the fix we want, what WILL BE (should be) the end of all this is #1280 so from that, we'll make a fine and euwe branch so it all gets in alrite alrite

@simaishi
Copy link
Contributor

@AllenBW #1280 was backported to Fine via #1282. Is this PR still needed for Fine branch?

@AllenBW
Copy link
Member Author

AllenBW commented Jan 15, 2018

@simaishi Nope!! This pr ended up not being a fix, no need to backport it.

@simaishi simaishi removed the fine/yes label Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants