Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG#1174-Create resouce-detail md/sm viewport layouts #1175

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Oct 26, 2017

closes #1174
MD and SM viewport sizes have different card layouts

after

screen shot 2017-10-26 at 3 10 10 pm

before

screen shot 2017-10-26 at 3 09 58 pm

@AllenBW AllenBW added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Oct 26, 2017

cc @Loicavenel @serenamarie125

@AllenBW AllenBW changed the title BUG#1174-Create resouce-detail md/sma viewport layouts BUG#1174-Create resouce-detail md/sm viewport layouts Oct 26, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commit AllenBW@4a5f9e8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@chriskacerguis chriskacerguis self-assigned this Oct 26, 2017
@chriskacerguis
Copy link
Contributor

Just for the sake of completeness, we need to resolve this issue (which exists in this PR, but is out of scope). #1159

@serenamarie125
Copy link

The aggregate status cards look so much better @AllenBW this is responsive design 💯 👏 👏 👏

Copy link

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @AllenBW thanks for working on this!

@serenamarie125
Copy link

@miq-bot add_labels ux/approved

@serenamarie125
Copy link

@miq-bot remove_labels ux/review

@miq-bot miq-bot removed the ux/review label Oct 27, 2017
@chriskacerguis chriskacerguis merged commit 4ab5134 into ManageIQ:master Oct 27, 2017
@serenamarie125
Copy link

fyi @Loicavenel

@AllenBW AllenBW deleted the bug/#1174-resource-details-1st-row-cards branch October 30, 2017 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource details first row cards should adjust to smaller screens
4 participants