BUG#1167-Restores rbac permissiosn and camera eventicon

[AllenBW]

closes #1167

Look camera icon is back! also we have create in the main dropdown and delete in the row kebab

@Loicavenel @serenamarie125 did i miss anything on this page?

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1507714

[miq-bot]

Checked commit AllenBW@4ab516d with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

[serenamarie125]

@Loicavenel shouldn't the button group be called "Snapshots"? I think that's what it is called when on the VM level.

If the name of the command button group is Snapshots, you should be able to change the menu item labels to be:

• Create
• Delete All

regardless, we need to make sure these are consistent when in the Snapshot View versus the VM Details view. Can you include screenies of both of the button group menu items?

[Loicavenel]

@serenamarie125, Button has to be contextual.

• VM details: Button Snapshots: View & Create
• Service Level: on resource line: Button Snapshots: View & Create
• Snapshot view: I don't think we should call the button SnapShot anymore.. we are in... BUT in place to call it Configuration: we should show the 2 Buttons: Create and Delete All, we have enough place for it.. we save one click :)

And don't forget in Snapshot view we should offer per Snapshot with Kebab menu: Delete (always) and Revert (where it does apply)

[AllenBW]

Great discussion! Gonna play parent and suggest that we merge this pr, open an issue to continue the discussion as whats being discussed exceeds the scope of this work. @Loicavenel @serenamarie125 ?

[chriskacerguis]

@serenamarie125 and @Loicavenel thoughts on @AllenBW 's suggestion?

[Loicavenel]

looks good for me... We should re-discuss the "Configuration" button later.. I think when there is only 2 buttons, it may be better to show them both than have to click on configuration

[serenamarie125]

This is the tough part with PRs which cover multiples. Approving as not to block progress.

[serenamarie125]

@miq-bot add_labels ux/approved

[serenamarie125]

@miq-bot remove_labels ux/review

[serenamarie125]

Thanks for bringing back the camera icon!