Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace supports_launch_cockpit with supports_cockpit #1165

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Replace supports_launch_cockpit with supports_cockpit #1165

merged 1 commit into from
Oct 26, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Oct 26, 2017 •
edited
Loading

closes #1164

@AllenBW AllenBW added the bug label Oct 26, 2017
@AllenBW AllenBW added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commit AllenBW@1d97b30 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@AllenBW AllenBW added the wip label Oct 26, 2017
@AllenBW AllenBW changed the title Replace supports_launch_cockpit with supports_cockpit [WIP]Replace supports_launch_cockpit with supports_cockpit Oct 26, 2017
@AllenBW AllenBW changed the title [WIP]Replace supports_launch_cockpit with supports_cockpit Replace supports_launch_cockpit with supports_cockpit Oct 26, 2017
@AllenBW AllenBW removed the wip label Oct 26, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Oct 26, 2017

@jntullo this look 👍 to you?

@chriskacerguis chriskacerguis self-assigned this Oct 26, 2017
@chriskacerguis
Copy link
Contributor

Looks good to me, but I'll wait for @jntullo to give a 👍

jntullo
jntullo approved these changes Oct 26, 2017
View reviewed changes
Copy link

@jntullo jntullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@chriskacerguis chriskacerguis merged commit 586a3a2 into ManageIQ:master Oct 26, 2017
@AllenBW AllenBW deleted the bug/#1164-supports_cockpit branch October 26, 2017 14:38
@AllenBW AllenBW mentioned this pull request Oct 26, 2017
Closed
@simaishi
Copy link
Contributor

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1501246

@AllenBW AllenBW restored the bug/#1164-supports_cockpit branch November 1, 2017 14:28
@AllenBW AllenBW mentioned this pull request Nov 1, 2017
Closed
@AllenBW AllenBW deleted the bug/#1164-supports_cockpit branch November 1, 2017 14:31
@AllenBW AllenBW mentioned this pull request Nov 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

@jntullo jntullo jntullo approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace support_launch_cockpit? decorator with supports_cockpit?
5 participants
@AllenBW @miq-bot @chriskacerguis @simaishi @jntullo