Adds loading spinner using pf-empty-state #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenBW
force-pushed
the
enhancement/#1149-loading-spinner
branch
from
09f7c15 to
8b45bb2
Compare
|
@AllenBW cool! Can you change the text to just say "Loading" without any ellipses? |
AllenBW
force-pushed
the
enhancement/#1149-loading-spinner
branch
from
8b45bb2 to
934b6a5
Compare
|
@serenamarie125 updated! |
|
@miq-bot add_labels ux/approved |
|
Checked commit AllenBW@934b6a5 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot remove_labels ux/review |
|
perfect, thank you @AllenBW 👏 👏 |
chriskacerguis
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1149
after
before
as per patternfly/patternfly-design#466
I know this design doesn't use words.... but it costs us nothing to add them, and only adds further clarity