-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical server page #970
Closed
+930
−26
Closed
Physical server page #970
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
ca99b62
[Routes] Adds routes to physical_server
95edeb1
[EmsCommon] Adds physical_server flags
0ef30c0
[ui_constants] Adds physical_server structure
d60cc0a
[QuadIcon] Adds PhysicalServer structure
3c0e12f
[TextualSummary] Adds physical server flag
8affee9
[TextualSummary] Adds physical server flag
aa60337
[PhysicalServerFlags] Adds physical server flag
92c7549
[PhysicalServerViews] Adds all physical server views
4feb863
[PhysicalServerController] Adds physical server's controller
7142a11
[PhysicalServerToolbar] Adds physical server's toolbar structure.
bef6016
Add helpers to physical server pages
471a4e2
Change physical infra helpers
fb91056
Add images assets to physical server pages
ea20828
[Fix] Fixes all warning made by rubocop
0a3a4a3
[Fix] Fixes warning in files made by rubocop
4b2916a
[Fix] Fixes of warning made by rubocop into views and helpers of phys…
7bb757a
[Fix] Fixing some issues
7ad7e4b
[Fix] Changes html_safe to safe_join
019c7f4
[Typo] Typo some errors warning by rubocop
fefe826
[Typo] Delete a blank space after backslash
4d82e5d
[Fix] Turns into hash rockets syntax
5c0ef75
[Fix] Inserts '.try' method call
dc082d9
Merge remote-tracking branch 'manageiq/master' into physical_server_page
6d646bc
[BugFix] Changes the attribute methods call
26de5af
Create fetures for physical servers toolbar's buttons.
gabrielsvinha 4b08d75
Update ci processing with methods for toolbar buttons
gabrielsvinha 87c39e4
Update toolbar button with modify methods
gabrielsvinha f3c5a59
Insert cases for ems common show toolbar buttons
gabrielsvinha f069e05
Update textual summary name methods
gabrielsvinha 19d23a1
Fix methods calls for physical server center button
gabrielsvinha f3f6bdc
Merge remote-tracking branch 'ManageIQ/master' into physical_server_page
gabrielsvinha 9b82528
Remove & operators from physical server textual summary
gabrielsvinha 7e836c4
Removes vms variable.
gabrielsvinha 762d426
Fix ems_common controller
walteraa 3f36681
Merge remote-tracking branch 'manageiq/master' into physical_server_page
walteraa 8adb93b
Fix rubocop issues
walteraa 301bb36
Fix rubocup styles for physical server textual summary
gabrielsvinha 1c139d0
Merge branch 'physical_server_page' of github.com:lenovo/manageiq-ui-…
gabrielsvinha 017ae3f
fixed robocop issues
MaysaMacedo 088fb68
Fix rubocup styles for physical server textual summary
gabrielsvinha 0fc2547
Merge remote-tracking branch 'ManageIQ/master' into physical_server_page
gabrielsvinha 4bfd07a
merged 'physical_server_page' into fix
MaysaMacedo 462f14f
Merge remote-tracking branch 'upstreamMIQ/master' into physical_serve…
MaysaMacedo 13ee483
Fix CI processing controller
walteraa 420a230
Merge remote-tracking branch 'upstream/physical_server_page' into phy…
MaysaMacedo ee96de7
fixed code climate issues
MaysaMacedo 6e61f01
fixed rubocop issues
MaysaMacedo fd8c51e
Merge branch 'physical_server_page_fix' into HEAD
MaysaMacedo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Removes vms variable.
Removes unused variable in ci_processing;rb
commit 7e836c49f18b9be4f9159f37a6ae8187ee676442
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this change related to
Physical Server
?If it's not related, please avoid making changes like these since it disturbs the flow of the review process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We made a merge from ManageIQ/master and this variable remained, this was blocking Travis because it's an unused variable.