[WIP] Enable Floating IPs delete/edit for FloatingIP controller

[PanSpagetka]

Enable Floating IPs delete/edit buttons for FloatingIPController. It seems to work in UI, but I would appreciate review from someone who is familiar with FloatingIPs.
Probably related with: ManageIQ/manageiq#12551

@gildub @ZitaNemeckova please review

[miq-bot]

Checked commit PanSpagetka@adf7dc4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 4 offenses detected

app/helpers/application_helper/toolbar/floating_ips_center.rb

• ❗ - Line 25, Col 64 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 26, Col 13 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• ❗ - Line 27, Col 13 - Style/FirstParameterIndentation - Indent the first parameter one step more than the start of the previous line.
• ❗ - Line 35, Col 64 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

[dclarizio]

@PanSpagetka I think we'll need a BZ for backport to Fine

[mzazrivec]

When editing amazon floating IP, I get the following error during form submit:

Error caught: [NoMethodError] undefined method `update_floating_ip_queue' for #<ManageIQ::Providers::Amazon::NetworkManager::FloatingIp:0x007f4d8566c0e0>
Did you mean?  update_attribute
~/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activemodel-5.0.2/lib/active_model/attribute_methods.rb:433:in `method_missing'
manageiq-ui-classic/app/controllers/floating_ip_controller.rb:190:in `update'

[mzazrivec]

I'm marking this as a work in progress pull request until the error above is resolved / explained.

Perhaps @gildub can shine some light on the error above.

[ZitaNemeckova]

@PanSpagetka [NoMethodError] means that you are trying to update a floating IP from a provider that doesn't support it. I saw similar error when I worked on ManageIQ/manageiq#12551 . Maybe ManageIQ/manageiq@71604a4#diff-d0f84516ffce9ee3e076b7da2085ae7bR232 can be an inspiration how to fix it.

[gildub]

@ZitaNemeckova, @dclarizio and @PanSpagetka

Sorry I missed that one, looking at it...

[gildub]

@PanSpagetka,

@ZitaNemeckova, is right about the action being triggered from a provider that doesn't support it.

SupportFreaturesMixin is needed and has not made it to floating IPs. I'm going to add a patch to address the later and will link it.

[gildub]

@ZitaNemeckova,

#1580 should help to work around unsupported providers. Can you please rebase using it and let me know how it goes, please don't hesitate to reach out if you need help.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!