Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move controller specs #96

Merged
merged 4 commits into from
Jan 9, 2017
Merged

Move controller specs #96

merged 4 commits into from
Jan 9, 2017

Conversation

durandom
Copy link
Member

@durandom durandom commented Jan 9, 2017 •
edited by miq-bot
Loading

  • moving shared controller specs from manageiq core
  • require all shared controller specs in spec_helper from UI engine rather than miq core
  • move amazon to some tested controllers, they have been removed from the amazon provider repo here ManageIQ/manageiq-providers-amazon@be4f55a

to decouple those shared example from provider implementations one could
a) check subclasses of e.g. CloudSubnet and test for all that are implemented or
b) try to make the specs work for the base class of CloudSubnet

@miq-bot assign @martinpovolny
@miq-bot add_labels test

cc @Fryguy @bdunne

@miq-bot miq-bot added the test label Jan 9, 2017
@durandom durandom mentioned this pull request Jan 9, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2017

Checked commits durandom/manageiq-ui-classic@230f322~...f196506 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
25 files checked, 0 offenses detected
Everything looks good. 🍪

skateman
skateman approved these changes Jan 9, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the fact that it's green makes me sure it's good to merge :)

@martinpovolny martinpovolny merged commit 7b7ef87 into ManageIQ:master Jan 9, 2017
@martinpovolny martinpovolny added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 9, 2017
bdunne
bdunne reviewed Jan 9, 2017
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@durandom durandom deleted the move_controller_specs branch January 9, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

@skateman skateman

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@durandom @miq-bot @skateman @bdunne @martinpovolny