Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor delete domain automate method (RBAC related) #956

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Refactor delete domain automate method (RBAC related) #956

merged 1 commit into from
Apr 12, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Apr 7, 2017 •
edited by martinpovolny
Loading

Refactor delete_domain automate method, should be replaced with RBAC safe method when ManageIQ/manageiq#14665 is merged.

@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

Checked commit PanSpagetka@2979b0c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/controllers/miq_ae_class_controller.rb

  • ❗ - Line 1844, Col 9 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

@martinpovolny martinpovolny changed the title Refactor delete domain automate method Refactor delete domain automate method (RBAC related) Apr 9, 2017
@martinpovolny martinpovolny added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 12, 2017
@martinpovolny martinpovolny merged commit ce23ffe into ManageIQ:master Apr 12, 2017
simaishi pushed a commit that referenced this pull request Apr 13, 2017
@martinpovolny @simaishi
Merge pull request #956 from PanSpagetka/refactor-delete-domain-method
ec4cf07 
Refactor delete domain automate method (RBAC related)
(cherry picked from commit ce23ffe)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit ec4cf07188ff90bc74f7ac0fc9abcc6e4608d34b
Author: Martin Povolny <[email protected]>
Date:   Wed Apr 12 13:54:12 2017 +0200

    Merge pull request #956 from PanSpagetka/refactor-delete-domain-method
    
    Refactor delete domain automate method (RBAC related)
    (cherry picked from commit ce23ffe4687d995d4a47ac9b9f2d113ab8b84a4c)

@martinpovolny martinpovolny mentioned this pull request Jun 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpichler lpichler lpichler approved these changes

Assignees

@martinpovolny martinpovolny

Labels
fine/backported rbac refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PanSpagetka @miq-bot @simaishi @lpichler @martinpovolny