Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed stdout format to be html #948

Merged
merged 1 commit into from
Apr 7, 2017
Merged

changed stdout format to be html #948

merged 1 commit into from
Apr 7, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Apr 6, 2017 •
edited
Loading

@bzwei
Copy link
Contributor

bzwei commented Apr 6, 2017

@h-kataria the job output is now in html format. The display component need to be a browser type, showing formatted text based on the html body. It should not show the html text including html tags.

@h-kataria
Copy link
Contributor Author

@bzwei we are using codemirror component that displays raw html in the textbox with line numbers and i do not think there is a way to tell it to evaluate the html tags and show output of that in the box. @dclarizio do you know if we can do that?

@h-kataria
Copy link
Contributor Author

@bzwei @dclarizio another way to display this output would be to eliminate codemirror and show the display in a box, we will loose line numbers in that case, see screenshot below:
screenshot from 2017-04-06 15-59-20

@bzwei
Copy link
Contributor

bzwei commented Apr 6, 2017

@h-kataria not showing line number is fine. There is no meaning of line number in this case anyway. Curious why the text are not colored. The html contains style sheet defining font colors.

@h-kataria h-kataria force-pushed the use_html_format_for_stdout branch from e3adf16 to 2a2e546 Compare April 7, 2017 15:43
@h-kataria
Copy link
Contributor Author

@bzwei @dclarizio please review/test, updated screeshot in the first comment

@h-kataria h-kataria force-pushed the use_html_format_for_stdout branch 2 times, most recently from c89ed45 to 423aeb7 Compare April 7, 2017 15:58
@bzwei
Copy link
Contributor

bzwei commented Apr 7, 2017

Looks good. Thanks!

@h-kataria h-kataria force-pushed the use_html_format_for_stdout branch 3 times, most recently from 903b477 to 3239eed Compare April 7, 2017 20:51
@h-kataria
changed stdout format to be html
2f280f9 
Added new JS controller to handle sanitize and render html on the screen.

https://bugzilla.redhat.com/show_bug.cgi?id=1439273
@h-kataria h-kataria force-pushed the use_html_format_for_stdout branch from 3239eed to 2f280f9 Compare April 7, 2017 20:55
@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

Checked commit h-kataria@2f280f9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🏆

@dclarizio dclarizio merged commit f3c6991 into ManageIQ:master Apr 7, 2017
@dclarizio dclarizio added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 7, 2017
simaishi pushed a commit that referenced this pull request Apr 11, 2017
@simaishi
Merge pull request #948 from h-kataria/use_html_format_for_stdout
7779288 
changed stdout format to be html
(cherry picked from commit f3c6991)

https://bugzilla.redhat.com/show_bug.cgi?id=1441295
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 7779288937e2e1ae078f9def20a4087fd59d3dcf
Author: Dan Clarizio <[email protected]>
Date:   Fri Apr 7 14:13:07 2017 -0700

    Merge pull request #948 from h-kataria/use_html_format_for_stdout
    
    changed stdout format to be html
    (cherry picked from commit f3c6991eaefa6482fc609c8913ddadb0234877ce)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441295

@h-kataria h-kataria deleted the use_html_format_for_stdout branch April 18, 2017 19:59
@himdel himdel mentioned this pull request Jun 6, 2019
Merged
Hyperkid123 pushed a commit to Hyperkid123/manageiq-ui-classic that referenced this pull request Jun 11, 2019
@himdel @Hyperkid123
Remove textual_code_mirror layout
cb7f1a2 
unused since ManageIQ#948 (2f280f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug fine/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @bzwei @miq-bot @simaishi @dclarizio