Made changes to code to only access name if record exists. #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
reviewed
Apr 6, 2017
| end | ||
| end | ||
| playbook_details | ||
| end | ||
|
|
||
| def fetch_name_from_object(klass, id) | ||
| item = klass.find_by(:id => id) | ||
| item ? item.name : nil |
There was a problem hiding this comment.
Replace these with: klass.find_by(:id => id).try(:name)
Ansible objects selected when adding Catalog Item could have been deleted from database so need to check for their existence before accessing their names to be displayed on summary screen. https://bugzilla.redhat.com/show_bug.cgi?id=1439144
h-kataria
force-pushed
the
access_record_attributes_if_record_exists
branch
from
2154544 to
98c0cde
Compare
|
Checked commit h-kataria@98c0cde with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gmcculloug made suggested change. |
simaishi
pushed a commit
that referenced
this pull request
Apr 6, 2017
…cord_exists Made changes to code to only access name if record exists. (cherry picked from commit c1d9f9f) https://bugzilla.redhat.com/show_bug.cgi?id=1439948
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible objects selected when adding Catalog Item could have been deleted from database so need to check for their existence before accessing their names to be displayed on summary screen.
https://bugzilla.redhat.com/show_bug.cgi?id=1439144
@gmcculloug @bzwei please test