Fix Add Datasource via existing driver Issue

[mtho11]

This fixes an issue where the JDBC Driver for existing drivers that was not pulling the data from the WildFly/EAP server but instead, incorrectly from defaults. So it would always try to create the datasource using the default name (like 'h2') instead of the custom name returned from the Wildfly server. Another issue, where username/password/securityDomain was empty it would send them as empty strings to the server instead of not sending them at all.

Links

• https://bugzilla.redhat.com/show_bug.cgi?id=1427141

Testing Instructions

As this is an asynchronous operation, the best way to test this is to monitor the logs of the WildFly/EAP server and make sure there are no errors during Datasource creation. Running the Hawkular Agent in debug logging mode helps if there are issues

[mtho11]

@miq-bot add_label middleware, bug, fine/yes

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[abonas]

If this is a BZ, please paste a link to it.
Also, it will be helpful to have a more detailed description - what was specifically the issue/bug fixed here?

[mtho11]

@miq-bot add_label angular dialogs

[mtho11]

@abonas yes, I don't usually link to BZs, screenshots, etc until it's not WIP.

[mtho11]

Ignoring the codeclimate warning here. The similiar code warning is a false positive and 3 instances of 'Replace double quotes with Single Quotes' should be in a different PR like we discussed last week.

[mtho11]

@miq-bot assign @abonas

[abonas]

@abonas yes, I don't usually link to BZs, screenshots, etc until it's not WIP.

why? :)

[abonas]

@miq-bot assign @karelhala
@karelhala please review

[abonas]

@karelhala @mtho11 what's the status of this bug fix?

[mtho11]

@abonas from my perspective it is done. Just need @karelhala to verify the fix doesn't show repeated items in the existing JDBC driver list. So, the test is to add several JDBC drivers and see that they show up and do not repeat.

[karelhala]

Github didn't submit my codereview...

Looks good, however as codeclimate complains use single quotes instead of double quotes please.

[miq-bot]

Checked commits https://github.com/mtho11/manageiq-ui-classic/compare/52e2c50e2044bcc238542025428b804eb50745f0~...1d9ca128dc54919271857ff5c67d924e02026e9d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

[mtho11]

Double quotes changed to single quotes. The other codeclimate issue is a false positive.
@abonas good to go.

[abonas]

@miq-bot assign @dclarizio

[simaishi]

Fine backport details:

$ git log -1
commit 754057083a489f5f52d5ec107542cb7b37e4489d
Author: Dan Clarizio <[email protected]>
Date:   Thu Apr 20 03:05:41 2017 -0700

    Merge pull request #941 from mtho11/ds_add_via_existing_driver2
    
    Fix Add Datasource via existing driver Issue
    (cherry picked from commit e928b351000817355397803a2a99db219d0cb6fc)