Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved menus under Automation maintab around #921

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Apr 4, 2017

Moved menus under Automation manitab around to make Ansible/Playbooks as default landing page when clicking on maintab Automation or when clicking on second level tab Ansible.

https://bugzilla.redhat.com/show_bug.cgi?id=1437189

before:
before

before2

after:
after

after2

@dclarizio please review.

Moved menus under Automation manitab around to make Ansible/Playbooks as default landing page when clicking on maintab Automation or when clicking on second level tab Ansible.

https://bugzilla.redhat.com/show_bug.cgi?id=1437189
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2017

Checked commit h-kataria@41026f4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@dclarizio
Copy link

@h-kataria is there a matching PR to move the features around in the features tree?

@h-kataria
Copy link
Contributor Author

@dclarizio Product Features tree uses default_menus to build main/second level tabs(nodes) in the tree, so we do not need any additional changes to handle that

@h-kataria h-kataria changed the title Moved menus under Automation manitab around Moved menus under Automation maintab around Apr 4, 2017
@dclarizio dclarizio merged commit f7c01da into ManageIQ:master Apr 4, 2017
@dclarizio dclarizio added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 4, 2017
simaishi pushed a commit that referenced this pull request Apr 5, 2017
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2017

Fine backport details:

$ git log -1
commit 73ec37f6a687c2a269288cdeef1249b77ac87f6f
Author: Dan Clarizio <[email protected]>
Date:   Tue Apr 4 13:12:16 2017 -0700

    Merge pull request #921 from h-kataria/automation_menu_reordering
    
    Moved menus under Automation maintab around
    (cherry picked from commit f7c01da8c4ab8a195257da6f7eaad2691175a29b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1439310

@h-kataria h-kataria deleted the automation_menu_reordering branch April 18, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants