$scope.$on('destroy') should be '$destroy' #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'destroy' would need to be a custom event the intent behind that code was definitely the $destroy event which happens when destroyin the scope
Merged
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/ef2eb3034c5635eae095c8850a153bb1e0fbd94e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2017
$scope.$on('destroy') should be '$destroy'
(cherry picked from commit eb42b56)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$scope.$on('destroy', ...)listens for a custom event called destroy, which we never produce.The intent behind that code was definitely to listen for the
$destroyevent which happens when destroying the scope.