[WIP] Request info summary conversion

[jeffibm]

This PR is on an experimental stage -

[miq-bot]

Checked commit jeffbonson@cb12f1c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
6 files checked, 52 offenses detected

app/helpers/request_info_helper.rb

• ⚠️ - Line 57, Col 22 - Lint/UnusedMethodArgument - Unused method argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used. If it's unnecessary, remove it. You can also write as is_field_radio(*) if you want the method to accept any arguments but don't care about them.
• ⚠️ - Line 67, Col 11 - Lint/UselessAssignment - Useless assignment to variable - field_id. Did you mean field_hash?
• ❗ - Line 27, Col 5 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 30, Col 7 - Naming/PredicateName - Rename is_credential_key to credential_key?.
• ❗ - Line 32, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 33, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 34, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 35, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 36, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 37, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 38, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 39, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 40, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 41, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 42, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 43, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 44, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 45, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 46, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 47, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 48, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 51, Col 7 - Naming/PredicateName - Rename is_field_checkbox to field_checkbox?.
• ❗ - Line 53, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 54, Col 7 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 57, Col 7 - Naming/PredicateName - Rename is_field_radio to field_radio?.
• ❗ - Line 61, Col 39 - Naming/MethodParameterName - Only use lowercase characters for method parameter.
• ❗ - Line 61, Col 39 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 65, Col 46 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 66, Col 12 - Rails/Present - Use field_hash.present? instead of !field_hash.blank?.
• ❗ - Line 66, Col 9 - Style/Next - Use next to skip iteration.
• ❗ - Line 67, Col 22 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 67, Col 22 - Style/StringConcatenation - Prefer string interpolation to string concatenation.
• ❗ - Line 74, Col 5 - Style/RedundantReturn - Redundant return detected.

app/helpers/request_info_tabs_helper/request_info_environment_helper.rb

• ❗ - Line 17, Col 29 - Naming/MethodParameterName - Method parameter must be at least 3 characters long.
• ❗ - Line 24, Col 41 - Naming/MethodParameterName - Method parameter must be at least 3 characters long.
• ❗ - Line 28, Col 24 - Naming/MethodParameterName - Method parameter must be at least 3 characters long.

app/helpers/request_info_tabs_helper/request_info_hardware_helper.rb

• ❗ - Line 22, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 23, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 29, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 30, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 36, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 37, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 44, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 45, Col 3 - Layout/EmptyLineBetweenDefs - Expected 1 empty line between method definitions; found 2.

app/views/miq_request/_prov_wf.html.haml

• ⚠️ - Line 4 - 4 consecutive Ruby scripts can be merged into a single :ruby filter
• ⚠️ - Line 4 - Avoid using instance variables in partials views
• ⚠️ - Line 5 - 3 consecutive Ruby scripts can be merged into a single :ruby filter
• ⚠️ - Line 5 - Avoid using instance variables in partials views
• ⚠️ - Line 6 - Avoid using instance variables in partials views
• ⚠️ - Line 6 - Lint/UselessAssignment: Useless assignment to variable - tabname.
• ⚠️ - Line 7 - Line is too long. [89/80]
• ⚠️ - Line 8 - Line is too long. [155/80]

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).