[WIP] De explorization of infra networking pages #8579
Conversation
|
@miq-bot add_label enhancement |
|
@akhilkr128 unrecognized command 'add', ignoring... Accepted commands are: add_label, add_reviewer, request_review, assign, close_issue, cross_repo_test, move_issue, remove_label, rm_label, remove_reviewer, set_milestone, unassign |
|
@miq-bot add_label enhancement |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
1 similar comment
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
akhilkr128
force-pushed
the
network_switches_conversion
branch
from
e5a4827 to
64ef55f
Compare
akhilkr128
force-pushed
the
network_switches_conversion
branch
from
64ef55f to
352fb92
Compare
| @@ -30,6 +36,14 @@ def tagging_explorer_controller? | |||
| @explorer | |||
| end | |||
|
|
|||
| def show_searchbar? | |||
| @record.nil? ? true : false | |||
There was a problem hiding this comment.
| @record.nil? ? true : false | |
| @record.nil? |
| def index | ||
| @lastaction = "index" | ||
|
|
||
| build_accordions_and_trees |
There was a problem hiding this comment.
I realize this PR is still WIP, but deploraization should effectively remove accordions and trees entirely. Accordions would instead become separate menu items and each menu item would require separate controllers/views. Trees have to be discussed...in many places tree structures are really needed and can just be normal list-view tables, however in some places we still may need trees (as in the case of infra-networking), so we need to figure out how to present that.
cc @jeffibm
akhilkr128
force-pushed
the
network_switches_conversion
branch
from
352fb92 to
46d361d
Compare
|
Some comments on commits akhilkr128/manageiq-ui-classic@304711b~...46d361d app/controllers/infra_networking_controller.rb
|
|
Checked commits akhilkr128/manageiq-ui-classic@304711b~...46d361d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/controllers/infra_networking_controller.rb
app/helpers/infra_networking_helper/textual_summary.rb
app/views/infra_networking/hosts.html.haml
app/views/infra_networking/show.html.haml
app/views/infra_networking/show_list.html.haml |
Part of #6819
Before
After