Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers: redact username and password from custom attributes values when displaying #844

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

enoodle
Copy link

@enoodle enoodle commented Mar 30, 2017

This will hide sensitive information from being displayed as plain text.

redacted_custom_attributes

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1418791

@enoodle
Copy link
Author

enoodle commented Mar 30, 2017

@himdel until we decide what to do with #290, we should proceed with this which is 100% needed (see BZ)

@miq-bot
Copy link
Member

miq-bot commented Mar 30, 2017

Checked commit enoodle@5c64095 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/helpers/ems_container_helper/textual_summary.rb

@himdel himdel self-assigned this Mar 30, 2017
@himdel
Copy link
Contributor

himdel commented Mar 30, 2017

Agreed, this prevents sensitive data from being shown without (hopefully) being too restrictive in what we display.

Thanks @enoodle !

@himdel himdel merged commit 95610cc into ManageIQ:master Mar 30, 2017
@himdel himdel added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 30, 2017
simaishi pushed a commit that referenced this pull request Mar 31, 2017
Containers: redact username and password from custom attributes values when displaying
(cherry picked from commit 95610cc)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit dbdc8cb983c32d3e0e4745af01760ec7638e603d
Author: Martin Hradil <[email protected]>
Date:   Thu Mar 30 10:47:57 2017 +0000

    Merge pull request #844 from enoodle/real_reduct_of_http_proxy_values
    
    Containers: redact username and password from custom attributes values when displaying
    (cherry picked from commit 95610cc7b5eb230dec661823d91ab3b2188b5520)

@simon3z
Copy link
Contributor

simon3z commented Jun 22, 2017

@himdel @enoodle I feel that we should revert this one

@simon3z
Copy link
Contributor

simon3z commented Jun 22, 2017

@himdel @enoodle I feel that we should revert this one

I mean in the next release (we should keep it in fine).

@himdel
Copy link
Contributor

himdel commented Jun 23, 2017

Agreed .. though I'd probably wait until ManageIQ/manageiq#15398 (and the corresponding manageiq-schema PR) gets merged..

@simon3z
Copy link
Contributor

simon3z commented Jun 23, 2017

@himdel OK... can you file the PR (without merging it) so that we won't forget?

@himdel
Copy link
Contributor

himdel commented Jun 23, 2017

Sure :) .. #1596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants