-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containers: redact username and password from custom attributes values when displaying #844
Containers: redact username and password from custom attributes values when displaying #844
Conversation
Checked commit enoodle@5c64095 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/ems_container_helper/textual_summary.rb
|
Agreed, this prevents sensitive data from being shown without (hopefully) being too restrictive in what we display. Thanks @enoodle ! |
Containers: redact username and password from custom attributes values when displaying (cherry picked from commit 95610cc)
Fine backport details:
|
Agreed .. though I'd probably wait until ManageIQ/manageiq#15398 (and the corresponding manageiq-schema PR) gets merged.. |
@himdel OK... can you file the PR (without merging it) so that we won't forget? |
Sure :) .. #1596 |
This will hide sensitive information from being displayed as plain text.
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1418791