Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused configuration views #8272

Merged

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented May 20, 2022

Removed unused configuration view files.

These view files seem to be to produce a view similar to this:
Screen Shot 2022-05-20 at 12 33 09 PM

However the configuration pages were converted to a non explorer version in this pr: #6782

This PR removes these view files as I believe these should have been deleted due to pr: #6782 and are no longer needed.

Removing these files will also remove angular quadicon code which is a part of: #7603

Unchanged views before and after deletion:

Before:
Screen Shot 2022-05-20 at 12 29 30 PM
Screen Shot 2022-05-20 at 12 29 59 PM
Screen Shot 2022-05-20 at 12 30 15 PM
Screen Shot 2022-05-20 at 12 30 25 PM

After:
Screen Shot 2022-05-20 at 12 27 09 PM
Screen Shot 2022-05-20 at 12 27 20 PM
Screen Shot 2022-05-20 at 12 28 11 PM
Screen Shot 2022-05-20 at 12 28 32 PM

@miq-bot add_reviewer @Fryguy
@miq-bot add_reviewer @jeffibm
@miq-bot assign @jeffibm
@miq-bot add-label technical debt

@miq-bot
Copy link
Member

miq-bot commented May 20, 2022

Checked commit GilbertCherrie@65958ec with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - error parsing JSON result

@Fryguy Fryguy merged commit 1dd7353 into ManageIQ:master May 20, 2022
@Fryguy Fryguy assigned Fryguy and unassigned jeffibm May 20, 2022
@GilbertCherrie GilbertCherrie deleted the remove_unused_configuration_views branch May 20, 2022 17:43
@jeffibm jeffibm mentioned this pull request May 23, 2022
10 tasks
@GilbertCherrie GilbertCherrie mentioned this pull request Aug 17, 2022
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants