move AvailabilityMixin over to SupportsFeatureMixin #8266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbrock
commented
May 19, 2022
kbrock
commented
- convert is_available? to supports?
- convert supports_#{feature} to supports?(:feature)
- convert is_available? to supports?
- convert supports_#{feature} to supports?(:feature)
agrare
reviewed
May 19, 2022
Comment on lines
-204
to
-210
| Array.wrap(records).all? do |record| | ||
| if record.respond_to?("supports_#{feature}?") | ||
| record.supports?(feature) | ||
| else # TODO: remove with deleting AvailabilityMixin module | ||
| record.is_available?(feature) | ||
| end | ||
| end |
Fryguy
approved these changes
May 19, 2022
agrare
reviewed
May 19, 2022
| unless @feature.nil? || @record.nil? | ||
| if @record.kind_of?(ManageIQ::Providers::Openstack::InfraManager) | ||
| return true if %w[start stop].include?(@feature.to_s) | ||
| return false | ||
| end | ||
|
|
||
| return @record.is_available?(@feature) if @record.kind_of?(ManageIQ::Providers::Openstack::InfraManager::Host) | ||
| return @record.supports?(@feature) if @record.kind_of?(ManageIQ::Providers::Openstack::InfraManager::Host) |
There was a problem hiding this comment.
Unrelated to this change, but really want to get rid of this I'm very confused why this is in a seemingly generic "host_feature_button"
agrare
approved these changes
May 19, 2022
|
Some comments on commit kbrock@5c7d144 spec/controllers/storage_controller_spec.rb
|
|
Checked commit kbrock@5c7d144 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint app/helpers/application_helper/button/generic_feature_button_with_disable.rb
app/helpers/application_helper/button/host_feature_button.rb
app/helpers/application_helper/button/host_feature_button_with_disable.rb
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.