Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust styling of power state images #813

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Adjust styling of power state images #813

merged 1 commit into from
Mar 27, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Mar 27, 2017

This PR unifies the styling of power state images, allowing them share the "stretched" class introduced here: #778 It removes the styling exceptions in the helper and css. It also updates the "os-unknown" and "vendor-unknown" images for consistency.

Old
screen shot 2017-03-27 at 1 41 04 pm

New
screen shot 2017-03-27 at 1 31 54 pm

screen shot 2017-03-27 at 1 33 58 pm

@epwinchell
Copy link
Contributor Author

@miq-bot assign @himdel

@epwinchell
Copy link
Contributor Author

@miq-bot add_label graphics, enhancement

@himdel
Copy link
Contributor

himdel commented Mar 27, 2017

Looks good, tested in the UI...

Will merge when green..

@himdel himdel closed this Mar 27, 2017
@himdel himdel reopened this Mar 27, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/9636b7bc4d63d534a22fd0f564b344256c595d1d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍪

@h-kataria h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 27, 2017
@h-kataria h-kataria merged commit 2204d5e into ManageIQ:master Mar 27, 2017
@epwinchell epwinchell deleted the updated_power_state_icons branch October 25, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants