Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Volumes should honour tag visibility #808

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Container Volumes should honour tag visibility #808

merged 1 commit into from
Mar 27, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Mar 27, 2017 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434879

Volumes toolbar should be dispalyed with edit tags button:
tagvol

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

@miq-bot add_label compute/containers, bug

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

@simon3z @martinpovolny Please review

@zakiva zakiva mentioned this pull request Mar 27, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2017

Checked commit zakiva@c80cefa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

@h-kataria
Copy link
Contributor

@zakiva this PR is removing Add/Edit/Delete buttons from Container Volume toolbar, is that correct? I don't see any reference of that in the BZ.

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

@zakiva this PR is removing Add/Edit/Delete buttons from Container Volume toolbar, is that correct? I don't see any reference of that in the BZ.

@h-kataria yes, these buttons should not appear in the Container Volume toolbar. The toolbar was hidden so far, so the buttons were not there and thus are not mentioned in the BZ.

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 27, 2017
@h-kataria
Copy link
Contributor

codeclimate errors will be addressed by toolbar refactoring

@h-kataria h-kataria merged commit 157f1c1 into ManageIQ:master Mar 27, 2017
@moolitayer
Copy link

@miq-bot add_label fine/yes

@simaishi simaishi removed the fine/yes label Apr 24, 2017
@simaishi
Copy link
Contributor

Removing fine/yes as this got in before fine branch was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug compute/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zakiva @miq-bot @h-kataria @moolitayer @simaishi