Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert vm and template edit form #8072

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Jan 25, 2022

Fixes #6748
Fixes #6926
Closes #5862
Depends On: ManageIQ/manageiq-api#1118

Converted the VM Edit form to Carbon React. The same form can be accessed using the compute/infrastructure/virtual machines/ VMS and templates and compute/cloud/instances/ instances and images.

Before:
Screen Shot 2022-01-25 at 2 32 59 PM

After:
Screen Shot 2022-01-25 at 2 28 06 PM

@GilbertCherrie GilbertCherrie force-pushed the convert_vm_edit_form branch 2 times, most recently from 76f6942 to 177cb0a Compare January 25, 2022 14:42
@GilbertCherrie GilbertCherrie changed the title Convert vm edit form [WIP] Convert vm edit form Jan 25, 2022
@GilbertCherrie GilbertCherrie force-pushed the convert_vm_edit_form branch 6 times, most recently from 9a9de8c to 52198d0 Compare January 25, 2022 19:41
@GilbertCherrie
Copy link
Member Author

@miq-bot add_reviewer @kavyanekkalapu
@miq-bot add-label enhancement

@GilbertCherrie GilbertCherrie force-pushed the convert_vm_edit_form branch 2 times, most recently from f5e0c1f to 2f2b712 Compare January 31, 2022 16:46
@GilbertCherrie GilbertCherrie changed the title [WIP] Convert vm edit form Convert vm edit form Jan 31, 2022
@kavyanekkalapu kavyanekkalapu merged commit 396b239 into ManageIQ:master Jan 31, 2022
@kavyanekkalapu kavyanekkalapu changed the title Convert vm edit form Convert vm and template edit form Jan 31, 2022
@GilbertCherrie GilbertCherrie deleted the convert_vm_edit_form branch January 31, 2022 22:06
@kavyanekkalapu kavyanekkalapu mentioned this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form conversion: Compute/Infrastructure/Virtual machines Edit Edit VM Form - react
4 participants