Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate DOM IDs and broken flash messages in miq_ae_class_controller #801

Merged
merged 3 commits into from
Mar 27, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Mar 24, 2017

  • flash message related IDs are duplicate
  • class_fields_div is nesting (messed up update and replace)
  • form_group and form_div are used many times

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1405178

@martinpovolny martinpovolny removed the wip label Mar 24, 2017
@martinpovolny martinpovolny changed the title [WIP] Fix some duplicate DOM IDs in miq_ae_class_controller Fix some duplicate DOM IDs in miq_ae_class_controller Mar 24, 2017
@martinpovolny
Copy link
Member Author

@h-kataria : please, review

@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2017

Checked commits martinpovolny/manageiq-ui-classic@2a206bb~...3ba2746 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

@martinpovolny martinpovolny changed the title Fix some duplicate DOM IDs in miq_ae_class_controller Fix duplicate DOM IDs and broken flash messages in miq_ae_class_controller Mar 24, 2017
@h-kataria
Copy link
Contributor

looks good, verified fix in UI.

@h-kataria h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 27, 2017
@h-kataria h-kataria merged commit e809b39 into ManageIQ:master Mar 27, 2017
@simaishi
Copy link
Contributor

@martinpovolny 5 out of 6 files are conflicting... Please resolve conflict and create an Euwe-specific PR (referencing this one) or suggest other PRs to backport.

$ git status
On branch euwe
Your branch is up-to-date with 'origin/euwe'.
You are currently cherry-picking commit e809b39.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   app/views/miq_ae_class/_all_tabs.html.haml

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   app/controllers/miq_ae_class_controller.rb
	both modified:   app/views/miq_ae_class/_class_fields.html.haml
	both modified:   app/views/miq_ae_class/_class_instances.html.haml
	both modified:   app/views/miq_ae_class/_class_methods.html.haml
	both modified:   app/views/miq_ae_class/_class_props.html.haml

@simaishi
Copy link
Contributor

Changed to euwe/no as per ManageIQ/manageiq#15125 (comment)

@martinpovolny martinpovolny deleted the ae_class_dup_id_mess branch November 28, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants